Commit 28e33c40 authored by Robert Liao's avatar Robert Liao Committed by Commit Bot

Disable DevToolsManagerDelegateTest Tests That Rely on Maximization for Mac

MacViews does not yet implement maximized windows and a trivial
implementation doesn't seem to work.

BUG=834754,836327

Change-Id: I4fd6fbd4295134053cc58d028d0c2397088150a8
Reviewed-on: https://chromium-review.googlesource.com/1026350Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553668}
parent dcb7c8ab
......@@ -128,7 +128,14 @@ IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest, NormalWindowChangeBounds) {
CheckWindowBounds(gfx::Rect(200, 100, 500, 400));
}
IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest, NormalToMaximizedWindow) {
#if defined(OS_MACOSX)
// MacViews does not yet implement maximized windows: https://crbug.com/836327
#define MAYBE_NormalToMaximizedWindow DISABLED_NormalToMaximizedWindow
#else
#define MAYBE_NormalToMaximizedWindow NormalToMaximizedWindow
#endif
IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest,
MAYBE_NormalToMaximizedWindow) {
CheckIsMaximized(false);
SendCommand("maximized");
CheckIsMaximized(true);
......@@ -159,8 +166,14 @@ IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest,
CheckIsFullscreen(true);
}
#if defined(OS_MACOSX)
// MacViews does not yet implement maximized windows: https://crbug.com/836327
#define MAYBE_MaximizedToMinimizedWindow DISABLED_MaximizedToMinimizedWindow
#else
#define MAYBE_MaximizedToMinimizedWindow MaximizedToMinimizedWindow
#endif
IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest,
MaximizedToMinimizedWindow) {
MAYBE_MaximizedToMinimizedWindow) {
browser()->window()->Maximize();
CheckIsMaximized(true);
......@@ -198,7 +211,14 @@ IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest, ShowMinimizedWindow) {
CheckIsMinimized(false);
}
IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest, RestoreMaximizedWindow) {
#if defined(OS_MACOSX)
// MacViews does not yet implement maximized windows: https://crbug.com/836327
#define MAYBE_RestoreMaximizedWindow DISABLED_RestoreMaximizedWindow
#else
#define MAYBE_RestoreMaximizedWindow RestoreMaximizedWindow
#endif
IN_PROC_BROWSER_TEST_F(DevToolsManagerDelegateTest,
MAYBE_RestoreMaximizedWindow) {
browser()->window()->Maximize();
CheckIsMaximized(true);
SendCommand("normal");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment