Commit 28e371d5 authored by mlamouri's avatar mlamouri Committed by Commit bot

Revert of Fix lsan failure with ManifestParserTest.* (patchset #1 id:1 of...

Revert of Fix lsan failure with ManifestParserTest.* (patchset #1 id:1 of https://codereview.chromium.org/554043004/)

Reason for revert:
broke build

Original issue's description:
> Fix lsan failure with ManifestParserTest.*
>
> BUG=None
> TBR=rockot@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/36816846f1cf8ceea2f96d501ebc745c82349337
> Cr-Commit-Position: refs/heads/master@{#294870}

TBR=rockot@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/574433004

Cr-Commit-Position: refs/heads/master@{#294876}
parent 1dcbab8b
...@@ -54,7 +54,7 @@ base::NullableString16 ParseShortName( ...@@ -54,7 +54,7 @@ base::NullableString16 ParseShortName(
namespace content { namespace content {
Manifest ManifestParser::Parse(const base::StringPiece& json) { Manifest ManifestParser::Parse(const base::StringPiece& json) {
scoped_ptr<base::Value> value = base::JSONReader::Read(json); base::Value* value = base::JSONReader::Read(json);
if (!value) { if (!value) {
// TODO(mlamouri): get the JSON parsing error and report it to the developer // TODO(mlamouri): get the JSON parsing error and report it to the developer
// console. // console.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment