Commit 28fbdad1 authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Chromium LUCI CQ

profiler: fix ThreadProfilerPlatformConfigurationTest.IsSupported better

I missed one part of the test in r846127.

Bug: 1101339
Change-Id: I2e0cdc56c31800577baecf2e10cb233ab7311099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645205Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846246}
parent 2e756665
...@@ -88,9 +88,11 @@ TEST_F(ThreadProfilerPlatformConfigurationTest, IsSupported) { ...@@ -88,9 +88,11 @@ TEST_F(ThreadProfilerPlatformConfigurationTest, IsSupported) {
// https://crbug.com/1101399 // https://crbug.com/1101399
const bool on_canary = base::mac::IsAtMostOS10_15(); const bool on_canary = base::mac::IsAtMostOS10_15();
const bool on_dev = base::mac::IsAtMostOS10_15(); const bool on_dev = base::mac::IsAtMostOS10_15();
const bool on_default = base::mac::IsAtMostOS10_15();
#else #else
const bool on_canary = true; const bool on_canary = true;
const bool on_dev = true; const bool on_dev = true;
const bool on_default = true;
#endif #endif
EXPECT_FALSE(config()->IsSupported(version_info::Channel::UNKNOWN)); EXPECT_FALSE(config()->IsSupported(version_info::Channel::UNKNOWN));
EXPECT_EQ(on_canary, config()->IsSupported(version_info::Channel::CANARY)); EXPECT_EQ(on_canary, config()->IsSupported(version_info::Channel::CANARY));
...@@ -98,7 +100,7 @@ TEST_F(ThreadProfilerPlatformConfigurationTest, IsSupported) { ...@@ -98,7 +100,7 @@ TEST_F(ThreadProfilerPlatformConfigurationTest, IsSupported) {
EXPECT_FALSE(config()->IsSupported(version_info::Channel::BETA)); EXPECT_FALSE(config()->IsSupported(version_info::Channel::BETA));
EXPECT_FALSE(config()->IsSupported(version_info::Channel::STABLE)); EXPECT_FALSE(config()->IsSupported(version_info::Channel::STABLE));
EXPECT_TRUE(config()->IsSupported(base::nullopt)); EXPECT_EQ(on_default, config()->IsSupported(base::nullopt));
#endif #endif
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment