Commit 2940e719 authored by Austin Tankiang's avatar Austin Tankiang Committed by Commit Bot

Fix FilesAppBrowserTest.Test/showGridViewDrive

The test was flaking because a new banner was added to Drive. This
banner has a "Learn more" button that can be used to dismiss the banner,
so click it during the test.

Bug: 1147306
Change-Id: If241639b7db35fd8a2cd6bfd87776d22c04e2874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538865Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827710}
parent e1f913d7
......@@ -890,8 +890,7 @@ WRAPPED_INSTANTIATE_TEST_SUITE_P(
TestCase("showGridViewDownloads").DisableFilesNg(),
TestCase("showGridViewDownloads").InGuestMode(),
TestCase("showGridViewDownloads").FilesNg(),
// Flaky test: See crbug.com/1147306
// TestCase("showGridViewDrive"),
TestCase("showGridViewDrive"),
TestCase("showGridViewButtonSwitches"),
TestCase("showGridViewKeyboardSelectionA11y"),
TestCase("showGridViewTitles").FilesNg(),
......
......@@ -22,11 +22,12 @@ async function showGridView(rootPath, expectedSet) {
// Open Files app on |rootPath|.
const appId = await setupAndWaitUntilReady(rootPath);
// Dismiss the Drive banner so Grid View can display the all entries.
// Dismiss the Drive banners so Grid View can display the all entries.
if (rootPath === RootPath.DRIVE) {
if (await isFilesNg(appId)) {
await remoteCall.waitAndClickElement(
appId, '.drive-welcome-wrapper .banner-close');
await remoteCall.waitAndClickElement(appId, '#offline-learn-more');
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment