Skip to content

GitLab

T
tangled
Commit 2949be48 authored by msw@chromium.org's avatar msw@chromium.org
Browse files
Options

Rebase SpeechInputBubble on the new views bubble. 

I chose to use the local ContentView class to implement BubbleDelegateView.
SpeechInputBubbleImpl didn't fit well as a BubbleDelegateView, because:
-Instances are expected to outlive Widget closure or hide (not implemented).
-SpeechInputBubbleBase::Show would cause a naming conflict.
-SpeechInputBubbleController interactions made that approach difficult.

BUG=98323
TEST=SpeechInputBubbles function as before.

Review URL: http://codereview.chromium.org/8565003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110622 0039d316-1c4b-4281-b951-d872f2087c98
parent 31ac10f5
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 96 additions and 121 deletions
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment