Commit 295b2034 authored by evan@chromium.org's avatar evan@chromium.org

Make TabContentsView implementations use OVERRIDE

I want to change a function prototype and I'm scared of getting
it wrong in a subclass.

Review URL: http://codereview.chromium.org/7569022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95702 0039d316-1c4b-4281-b951-d872f2087c98
parent 7a6ba6ab
...@@ -45,29 +45,29 @@ class TabContentsViewGtk : public TabContentsView, ...@@ -45,29 +45,29 @@ class TabContentsViewGtk : public TabContentsView,
// TabContentsView implementation -------------------------------------------- // TabContentsView implementation --------------------------------------------
virtual void CreateView(const gfx::Size& initial_size); virtual void CreateView(const gfx::Size& initial_size) OVERRIDE;
virtual RenderWidgetHostView* CreateViewForWidget( virtual RenderWidgetHostView* CreateViewForWidget(
RenderWidgetHost* render_widget_host); RenderWidgetHost* render_widget_host) OVERRIDE;
virtual gfx::NativeView GetNativeView() const; virtual gfx::NativeView GetNativeView() const OVERRIDE;
virtual gfx::NativeView GetContentNativeView() const; virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
virtual gfx::NativeWindow GetTopLevelNativeWindow() const; virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;
virtual void GetContainerBounds(gfx::Rect* out) const; virtual void GetContainerBounds(gfx::Rect* out) const OVERRIDE;
virtual void SetPageTitle(const std::wstring& title); virtual void SetPageTitle(const std::wstring& title) OVERRIDE;
virtual void OnTabCrashed(base::TerminationStatus status, virtual void OnTabCrashed(base::TerminationStatus status,
int error_code); int error_code) OVERRIDE;
virtual void SizeContents(const gfx::Size& size); virtual void SizeContents(const gfx::Size& size) OVERRIDE;
virtual void RenderViewCreated(RenderViewHost* host); virtual void RenderViewCreated(RenderViewHost* host) OVERRIDE;
virtual void Focus(); virtual void Focus() OVERRIDE;
virtual void SetInitialFocus(); virtual void SetInitialFocus() OVERRIDE;
virtual void StoreFocus(); virtual void StoreFocus() OVERRIDE;
virtual void RestoreFocus(); virtual void RestoreFocus() OVERRIDE;
virtual void UpdatePreferredSize(const gfx::Size& pref_size); virtual void UpdatePreferredSize(const gfx::Size& pref_size) OVERRIDE;
virtual bool IsDoingDrag() const; virtual bool IsDoingDrag() const OVERRIDE;
virtual void CancelDragAndCloseTab(); virtual void CancelDragAndCloseTab() OVERRIDE;
virtual bool IsEventTracking() const; virtual bool IsEventTracking() const OVERRIDE;
virtual void CloseTabAfterEventTracking(); virtual void CloseTabAfterEventTracking() OVERRIDE;
virtual void GetViewBounds(gfx::Rect* out) const; virtual void GetViewBounds(gfx::Rect* out) const OVERRIDE;
// Backend implementation of RenderViewHostDelegate::View. // Backend implementation of RenderViewHostDelegate::View.
virtual void CreateNewWindow( virtual void CreateNewWindow(
......
...@@ -55,28 +55,28 @@ class TabContentsViewMac : public TabContentsView, ...@@ -55,28 +55,28 @@ class TabContentsViewMac : public TabContentsView,
// TabContentsView implementation -------------------------------------------- // TabContentsView implementation --------------------------------------------
virtual void CreateView(const gfx::Size& initial_size); virtual void CreateView(const gfx::Size& initial_size) OVERRIDE;
virtual RenderWidgetHostView* CreateViewForWidget( virtual RenderWidgetHostView* CreateViewForWidget(
RenderWidgetHost* render_widget_host); RenderWidgetHost* render_widget_host) OVERRIDE;
virtual gfx::NativeView GetNativeView() const; virtual gfx::NativeView GetNativeView() const OVERRIDE;
virtual gfx::NativeView GetContentNativeView() const; virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
virtual gfx::NativeWindow GetTopLevelNativeWindow() const; virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;
virtual void GetContainerBounds(gfx::Rect* out) const; virtual void GetContainerBounds(gfx::Rect* out) const OVERRIDE;
virtual void RenderViewCreated(RenderViewHost* host); virtual void RenderViewCreated(RenderViewHost* host) OVERRIDE;
virtual void SetPageTitle(const std::wstring& title); virtual void SetPageTitle(const std::wstring& title) OVERRIDE;
virtual void OnTabCrashed(base::TerminationStatus status, virtual void OnTabCrashed(base::TerminationStatus status,
int error_code); int error_code) OVERRIDE;
virtual void SizeContents(const gfx::Size& size); virtual void SizeContents(const gfx::Size& size) OVERRIDE;
virtual void Focus(); virtual void Focus() OVERRIDE;
virtual void SetInitialFocus(); virtual void SetInitialFocus() OVERRIDE;
virtual void StoreFocus(); virtual void StoreFocus() OVERRIDE;
virtual void RestoreFocus(); virtual void RestoreFocus() OVERRIDE;
virtual void UpdatePreferredSize(const gfx::Size& pref_size); virtual void UpdatePreferredSize(const gfx::Size& pref_size) OVERRIDE;
virtual bool IsDoingDrag() const; virtual bool IsDoingDrag() const OVERRIDE;
virtual void CancelDragAndCloseTab(); virtual void CancelDragAndCloseTab() OVERRIDE;
virtual bool IsEventTracking() const; virtual bool IsEventTracking() const OVERRIDE;
virtual void CloseTabAfterEventTracking(); virtual void CloseTabAfterEventTracking() OVERRIDE;
virtual void GetViewBounds(gfx::Rect* out) const; virtual void GetViewBounds(gfx::Rect* out) const OVERRIDE;
// Backend implementation of RenderViewHostDelegate::View. // Backend implementation of RenderViewHostDelegate::View.
virtual void CreateNewWindow( virtual void CreateNewWindow(
......
...@@ -70,6 +70,8 @@ class TabContentsViewViews : public views::Widget, ...@@ -70,6 +70,8 @@ class TabContentsViewViews : public views::Widget,
virtual bool IsEventTracking() const; virtual bool IsEventTracking() const;
virtual void CloseTabAfterEventTracking(); virtual void CloseTabAfterEventTracking();
virtual void GetViewBounds(gfx::Rect* out) const OVERRIDE; virtual void GetViewBounds(gfx::Rect* out) const OVERRIDE;
// Implementation of RenderViewHostDelegate::View.
virtual void CreateNewWindow( virtual void CreateNewWindow(
int route_id, int route_id,
const ViewHostMsg_CreateWindow_Params& params) OVERRIDE; const ViewHostMsg_CreateWindow_Params& params) OVERRIDE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment