[TablesNG] Change the way columns affect grid size
What happens when table has more columns than cells? Should the extra columns be discarded, or used to table grid? If the columns are not discarded, and table has border spacing, each empty column would make table wider. Spec, and previous implemntations are not clear on what to do. Initial table spec had a concept of effective columns, where multiple columns could be treated as one for purpose of layout. New spec introduces the concept of track merging. https://www.w3.org/TR/css-tables-3/#dimensioning-the-row-column-grid--step2 It is a messy subject. I think cells could merge, but not columns. But then in some implementations (ours), columns could merge too. I investigated this because two wpt tests were failing in TablesNG: external/wpt/css/css-tables/html5-table-formatting-1.html external/wpt/css/css-tables/html5-table-formatting-2.html They also failed in FF/Legacy, but in different ways. The initial code trimmed the excess columns. New code does not trim the columns. This makes html5-table-formatting-2 pass all tests, and makes one extra test in html5-table-formatting-1 pass. The fix exposed a bug in ColumnGeometries sorting, ordering was not monotonic. Fixed that too. Bug: 958381 Change-Id: I9bd267f7e7782df7224f5db4611751ca10ff1aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583157Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835721}
Showing
Please register or sign in to comment