Commit 29886952 authored by dpapad's avatar dpapad Committed by Chromium LUCI CQ

Settings: Improve a11y linear navigation of the <site-list> UI element.

Fixing issues where:
 - "No sites added" was announced twice.
 - An invisible and empty paper-tooltip was in the navigation order.

Bug: 1117554
Change-Id: I9b35c149cb33178cb6c39ba1d314cde17e6bf644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574274Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834077}
parent 6ce57423
...@@ -42,7 +42,8 @@ ...@@ -42,7 +42,8 @@
hidden$="[[!showNoSearchResults_(searchFilter, sites.*)]]"> hidden$="[[!showNoSearchResults_(searchFilter, sites.*)]]">
<div class="list-item secondary">$i18n{searchNoResults}</div> <div class="list-item secondary">$i18n{searchNoResults}</div>
</div> </div>
<div class="list-frame menu-content vertical-list" id="listContainer"> <div class="list-frame menu-content vertical-list" id="listContainer"
hidden$="[[!hasSites_(sites.*)]]">
<iron-list items="[[getFilteredSites_(searchFilter, sites.*)]]" <iron-list items="[[getFilteredSites_(searchFilter, sites.*)]]"
preserve-focus risk-selection> preserve-focus risk-selection>
<template> <template>
...@@ -56,9 +57,8 @@ ...@@ -56,9 +57,8 @@
</iron-list> </iron-list>
</div> </div>
</div> </div>
<paper-tooltip id="tooltip" <paper-tooltip id="tooltip" hidden="[[!tooltipText_]]]"
fit-to-visible-bounds manual-mode fit-to-visible-bounds manual-mode position="top">
position="top">
[[tooltipText_]] [[tooltipText_]]
</paper-tooltip> </paper-tooltip>
<template is="dom-if" if="[[showEditExceptionDialog_]]" restamp> <template is="dom-if" if="[[showEditExceptionDialog_]]" restamp>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment