Commit 2998dc74 authored by Prashant Nevase's avatar Prashant Nevase Committed by Commit Bot

Correct dark-mode-images-grayscale virtual tests.

While organizing the virtual tests for dark mode images in grayscale,
common configurations were removed. But as earlier code did not have
grayscale argument explicitly set, the results were same as default
dark mode. This patch corrects the argument needed for grayscale and
now expected image results look grayish.

Bug: 1116914
Change-Id: Iddf66c043d754ee6ed1607ca5c6f9908afbed1ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434191Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Commit-Queue: Prashant Nevase <prashant.n@samsung.com>
Cr-Commit-Position: refs/heads/master@{#811538}
parent b440dea5
...@@ -279,7 +279,7 @@ ...@@ -279,7 +279,7 @@
{ {
"prefix": "dark-mode-images-grayscale", "prefix": "dark-mode-images-grayscale",
"bases": ["dark-mode/images"], "bases": ["dark-mode/images"],
"args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0,forceDarkModeImageStyle=1"] "args": ["--blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0,forceDarkModeImageGrayscale=1.0"]
}, },
{ {
"prefix": "presentation", "prefix": "presentation",
......
# This suite runs the tests in web_tests/dark-mode/images with # This suite runs the tests in web_tests/dark-mode/images with
# --blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0,forceDarkModeImageStyle=1 # --blink-settings=forceDarkModeEnabled=true,forceDarkModeImagePolicy=0,forceDarkModeImageGrayscale=1.0
# See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py. # See the virtual_test_suites() method in tools/blinkpy/web_tests/port/base.py.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment