Commit 29aa3d51 authored by sandersd@chromium.org's avatar sandersd@chromium.org

Remove by-reference implementations of blink::WebMediaPlayer::buffered()

This cleans up after r270870 following the blink-side changes.

BUG=360254

Review URL: https://codereview.chromium.org/282373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272626 0039d316-1c4b-4281-b951-d872f2087c98
parent 6bb9c71f
...@@ -184,12 +184,6 @@ void MediaSourceDelegate::InitializeDemuxer() { ...@@ -184,12 +184,6 @@ void MediaSourceDelegate::InitializeDemuxer() {
false); false);
} }
const blink::WebTimeRanges& MediaSourceDelegate::Buffered() {
buffered_web_time_ranges_ =
ConvertToWebTimeRanges(buffered_time_ranges_);
return buffered_web_time_ranges_;
}
blink::WebTimeRanges MediaSourceDelegate::Buffered() const { blink::WebTimeRanges MediaSourceDelegate::Buffered() const {
return ConvertToWebTimeRanges(buffered_time_ranges_); return ConvertToWebTimeRanges(buffered_time_ranges_);
} }
......
...@@ -67,7 +67,6 @@ class MediaSourceDelegate : public media::DemuxerHost { ...@@ -67,7 +67,6 @@ class MediaSourceDelegate : public media::DemuxerHost {
const UpdateNetworkStateCB& update_network_state_cb, const UpdateNetworkStateCB& update_network_state_cb,
const DurationChangeCB& duration_change_cb); const DurationChangeCB& duration_change_cb);
const blink::WebTimeRanges& Buffered();
blink::WebTimeRanges Buffered() const; blink::WebTimeRanges Buffered() const;
size_t DecodedFrameCount() const; size_t DecodedFrameCount() const;
size_t DroppedFrameCount() const; size_t DroppedFrameCount() const;
...@@ -206,8 +205,6 @@ class MediaSourceDelegate : public media::DemuxerHost { ...@@ -206,8 +205,6 @@ class MediaSourceDelegate : public media::DemuxerHost {
media::PipelineStatistics statistics_; media::PipelineStatistics statistics_;
media::Ranges<base::TimeDelta> buffered_time_ranges_; media::Ranges<base::TimeDelta> buffered_time_ranges_;
// Keep a list of buffered time ranges.
blink::WebTimeRanges buffered_web_time_ranges_;
MediaSourceOpenedCB media_source_opened_cb_; MediaSourceOpenedCB media_source_opened_cb_;
media::Demuxer::NeedKeyCB need_key_cb_; media::Demuxer::NeedKeyCB need_key_cb_;
......
...@@ -434,12 +434,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerAndroid::readyState() const { ...@@ -434,12 +434,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerAndroid::readyState() const {
return ready_state_; return ready_state_;
} }
const WebTimeRanges& WebMediaPlayerAndroid::buffered() {
if (media_source_delegate_)
return media_source_delegate_->Buffered();
return buffered_;
}
WebTimeRanges WebMediaPlayerAndroid::buffered() const { WebTimeRanges WebMediaPlayerAndroid::buffered() const {
if (media_source_delegate_) if (media_source_delegate_)
return media_source_delegate_->Buffered(); return media_source_delegate_->Buffered();
......
...@@ -98,7 +98,6 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer, ...@@ -98,7 +98,6 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
virtual bool supportsSave() const; virtual bool supportsSave() const;
virtual void setRate(double rate); virtual void setRate(double rate);
virtual void setVolume(double volume); virtual void setVolume(double volume);
virtual const blink::WebTimeRanges& buffered();
virtual blink::WebTimeRanges buffered() const; virtual blink::WebTimeRanges buffered() const;
virtual double maxTimeSeekable() const; virtual double maxTimeSeekable() const;
......
...@@ -511,18 +511,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::readyState() const { ...@@ -511,18 +511,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::readyState() const {
return ready_state_; return ready_state_;
} }
const blink::WebTimeRanges& WebMediaPlayerImpl::buffered() {
DCHECK(main_loop_->BelongsToCurrentThread());
media::Ranges<base::TimeDelta> buffered_time_ranges =
pipeline_.GetBufferedTimeRanges();
buffered_data_source_host_.AddBufferedTimeRanges(
&buffered_time_ranges, pipeline_.GetMediaDuration());
blink::WebTimeRanges buffered_web_time_ranges(
ConvertToWebTimeRanges(buffered_time_ranges));
buffered_web_time_ranges_.swap(buffered_web_time_ranges);
return buffered_web_time_ranges_;
}
blink::WebTimeRanges WebMediaPlayerImpl::buffered() const { blink::WebTimeRanges WebMediaPlayerImpl::buffered() const {
DCHECK(main_loop_->BelongsToCurrentThread()); DCHECK(main_loop_->BelongsToCurrentThread());
media::Ranges<base::TimeDelta> buffered_time_ranges = media::Ranges<base::TimeDelta> buffered_time_ranges =
......
...@@ -87,7 +87,6 @@ class WebMediaPlayerImpl ...@@ -87,7 +87,6 @@ class WebMediaPlayerImpl
virtual void setRate(double rate); virtual void setRate(double rate);
virtual void setVolume(double volume); virtual void setVolume(double volume);
virtual void setPreload(blink::WebMediaPlayer::Preload preload); virtual void setPreload(blink::WebMediaPlayer::Preload preload);
virtual const blink::WebTimeRanges& buffered();
virtual blink::WebTimeRanges buffered() const; virtual blink::WebTimeRanges buffered() const;
virtual double maxTimeSeekable() const; virtual double maxTimeSeekable() const;
...@@ -327,8 +326,6 @@ class WebMediaPlayerImpl ...@@ -327,8 +326,6 @@ class WebMediaPlayerImpl
media::ChunkDemuxer* chunk_demuxer_; media::ChunkDemuxer* chunk_demuxer_;
BufferedDataSourceHostImpl buffered_data_source_host_; BufferedDataSourceHostImpl buffered_data_source_host_;
// TODO(sandersd): Remove this cache. http://crbug.com/360254
blink::WebTimeRanges buffered_web_time_ranges_;
// Temporary for EME v0.1. In the future the init data type should be passed // Temporary for EME v0.1. In the future the init data type should be passed
// through GenerateKeyRequest() directly from WebKit. // through GenerateKeyRequest() directly from WebKit.
......
...@@ -301,11 +301,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerMS::readyState() const { ...@@ -301,11 +301,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerMS::readyState() const {
return ready_state_; return ready_state_;
} }
const blink::WebTimeRanges& WebMediaPlayerMS::buffered() {
DCHECK(thread_checker_.CalledOnValidThread());
return buffered_;
}
blink::WebTimeRanges WebMediaPlayerMS::buffered() const { blink::WebTimeRanges WebMediaPlayerMS::buffered() const {
DCHECK(thread_checker_.CalledOnValidThread()); DCHECK(thread_checker_.CalledOnValidThread());
return buffered_; return buffered_;
......
...@@ -75,7 +75,6 @@ class WebMediaPlayerMS ...@@ -75,7 +75,6 @@ class WebMediaPlayerMS
virtual void setRate(double rate); virtual void setRate(double rate);
virtual void setVolume(double volume); virtual void setVolume(double volume);
virtual void setPreload(blink::WebMediaPlayer::Preload preload); virtual void setPreload(blink::WebMediaPlayer::Preload preload);
virtual const blink::WebTimeRanges& buffered();
virtual blink::WebTimeRanges buffered() const; virtual blink::WebTimeRanges buffered() const;
virtual double maxTimeSeekable() const; virtual double maxTimeSeekable() const;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment