Commit 29b1fbd6 authored by Sergey Ulanov's avatar Sergey Ulanov Committed by Commit Bot

[Fuchsia] Fix runner scripts to stop test server spawner

Previously the net_unittests was not stopping test server spawner as
expected.
This change should help debug the linked bug: now if a test server is
not stopped by one of the tests it will be reported by the
SpawningServer.Stop() in the log.

Bug: 913156
Change-Id: If4ad371f4a03b4f44ca4f8cb51b2c8a2a328f647
Reviewed-on: https://chromium-review.googlesource.com/c/1387810Reviewed-by: default avatarFabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618410}
parent ab0964c8
...@@ -106,7 +106,7 @@ def main(): ...@@ -106,7 +106,7 @@ def main():
target.PutFile(args.test_launcher_filter_file, TEST_FILTER_PATH) target.PutFile(args.test_launcher_filter_file, TEST_FILTER_PATH)
child_args.append('--test-launcher-filter-file=' + TEST_FILTER_PATH) child_args.append('--test-launcher-filter-file=' + TEST_FILTER_PATH)
forwarder = None test_server = None
if args.enable_test_server: if args.enable_test_server:
test_server = SetupTestServer(target, test_concurrency) test_server = SetupTestServer(target, test_concurrency)
...@@ -115,9 +115,8 @@ def main(): ...@@ -115,9 +115,8 @@ def main():
args.output_directory, target, args.package, args.package_name, args.output_directory, target, args.package, args.package_name,
args.package_dep, child_args, run_package_args) args.package_dep, child_args, run_package_args)
if forwarder: if test_server:
forwarder.terminate() test_server.Stop()
forwarder.wait()
if args.test_launcher_summary_output: if args.test_launcher_summary_output:
target.GetFile(TEST_RESULT_PATH, args.test_launcher_summary_output) target.GetFile(TEST_RESULT_PATH, args.test_launcher_summary_output)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment