Skip to content

GitLab

T
tangled
Commit 29c5ee3c authored by creis's avatar creis Committed by Commit bot
Browse files
Options

Disable flaky UnloadTest.CrossSiteInfiniteBeforeUnloadSync on Mac. 

BUG=462671

Review URL: https://codereview.chromium.org/1143663003

Cr-Commit-Position: refs/heads/master@{#330244}
parent c1fd3a3d
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 9 deletions
chrome/browser/unload_browsertest.cc
View file @ 29c5ee3c
...@@ -238,15 +238,8 @@ IN_PROC_BROWSER_TEST_F(UnloadTest, CrossSiteInfiniteBeforeUnloadAsync) { ...@@ -238,15 +238,8 @@ IN_PROC_BROWSER_TEST_F(UnloadTest, CrossSiteInfiniteBeforeUnloadAsync) {
// Navigate to a page with an infinite beforeunload handler. // Navigate to a page with an infinite beforeunload handler.
// Then two two sync crosssite requests to ensure // Then two two sync crosssite requests to ensure
// we correctly nav to each one. // we correctly nav to each one.
// Flaky on Win and Linux; http://crbug.com/462671. // Flaky on Win, Linux, and Mac; http://crbug.com/462671.
#if defined(OS_WIN) || defined(OS_LINUX) IN_PROC_BROWSER_TEST_F(UnloadTest, DISABLED_CrossSiteInfiniteBeforeUnloadSync) {
#define MAYBE_CrossSiteInfiniteBeforeUnloadSync \
DISABLED_CrossSiteInfiniteBeforeUnloadSync
#else
#define MAYBE_CrossSiteInfiniteBeforeUnloadSync \
CrossSiteInfiniteBeforeUnloadSync
#endif
IN_PROC_BROWSER_TEST_F(UnloadTest, MAYBE_CrossSiteInfiniteBeforeUnloadSync) {
// Tests makes no sense in single-process mode since the renderer is hung. // Tests makes no sense in single-process mode since the renderer is hung.
if (base::CommandLine::ForCurrentProcess()->HasSwitch( if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSingleProcess)) switches::kSingleProcess))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment