Commit 29dfc166 authored by Yuzu Saijo's avatar Yuzu Saijo Committed by Commit Bot

[service worker] Add an additional CHECK to fix the crash

This CL adds an additional CHECK to ensure that the controller status
is REDUNDADNT when crash happens.

Bug: 1021718
Change-Id: I534d1198fb1f27368e41435d8127f6530a7e4bbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087500Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Reviewed-by: default avatarKenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Auto-Submit: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747703}
parent 7792b6e8
......@@ -739,9 +739,13 @@ void ServiceWorkerVersion::AddControllee(
// TODO(crbug.com/1021718): Change to DCHECK once we figure out the cause of
// crash.
CHECK(!base::Contains(controllee_map_, uuid));
// TODO(crbug.com/951571): Change to DCHECK once we figured out the cause of
// invalid controller status.
CHECK(status_ == ACTIVATING || status_ == ACTIVATED);
// TODO(yuzus, crbug.com/951571): Remove these CHECKs once we figure out the
// cause of crash.
CHECK_NE(status_, NEW);
CHECK_NE(status_, INSTALLING);
CHECK_NE(status_, INSTALLED);
CHECK_NE(status_, REDUNDANT);
if (base::FeatureList::IsEnabled(
features::kServiceWorkerTerminationOnNoControllee) &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment