Commit 29eab9c3 authored by Yi Su's avatar Yi Su Committed by Commit Bot

[sheriff] Fix the bug that causes ClearBrowsingDataSettingsTestCase to

fail on small screens.

The refactor work on Settings makes Privacy menu larger, thus the
"Clear Browsing Data" button is hidden on iPhone 5s due to the screen
size. The EG test, ClearBrowsingDataSettingsTestCase, doesn't scroll to
find the button, so it failed.

This CL will fix the bug and stop failures on iOS12beta.

TBR=edchin@chromium.org

Bug: 907194
Change-Id: I9fc50a0979b005bcc07628c0d7ae4b3be86050bf
Reviewed-on: https://chromium-review.googlesource.com/c/1345071Reviewed-by: default avataredchin <edchin@chromium.org>
Reviewed-by: default avatarYi Su <mrsuyi@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609950}
parent 2656ecd2
......@@ -35,9 +35,8 @@ using chrome_test_util::SettingsMenuPrivacyButton;
NSString* clearBrowsingDataDialogLabel =
l10n_util::GetNSString(IDS_IOS_CLEAR_BROWSING_DATA_TITLE);
[[EarlGrey selectElementWithMatcher:ButtonWithAccessibilityLabel(
clearBrowsingDataDialogLabel)]
performAction:grey_tap()];
[ChromeEarlGreyUI tapPrivacyMenuButton:ButtonWithAccessibilityLabel(
clearBrowsingDataDialogLabel)];
}
// Test that opening the clear browsing data dialog does not cause a crash
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment