[SYNC] Speculative fix for autofill change processor destroying on the wrong...

[SYNC] Speculative fix for autofill change processor destroying on the wrong thread. The data type manager should now tell any datatype controller that is not already stopping or not running to stop. Namely, this covers the MODEL_STARTING and ASSOCIATING cases, which weren't being covered before. Tests that can reproduce these race conditions still needed.

BUG=61804
TEST=unit,sync_integration,self

Review URL: http://codereview.chromium.org/6273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72458 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/sync/glue/data_type_manager_impl.cc

@@ -358,7 +358,8 @@ void DataTypeManagerImpl::FinishStop() {
   for (DataTypeController::TypeMap::const_iterator it = controllers_.begin();
        it != controllers_.end(); ++it) {
     DataTypeController* dtc = (*it).second;
-    if (dtc->state() == DataTypeController::RUNNING) {
+    if (dtc->state() != DataTypeController::NOT_RUNNING &&
+        dtc->state() != DataTypeController::STOPPING) {
       dtc->Stop();
       VLOG(1) << "Stopped " << dtc->name();
     }