Commit 29fbb051 authored by Megan Jablonski's avatar Megan Jablonski Committed by Commit Bot

[Translate] Remove identical language logic for the new Tab UI

When I rebased crrev.com/c/1921655 I accidentally reverted this
part of crrev.com/c/1918655.

Bug: 976352
Change-Id: I6d74e6d21f0b91fd41a9ba007a88c566c3e7bc6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935491Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719279}
parent bb3a996f
...@@ -696,14 +696,7 @@ void TranslateBubbleView::ShowOriginal() { ...@@ -696,14 +696,7 @@ void TranslateBubbleView::ShowOriginal() {
void TranslateBubbleView::ConfirmAdvancedOptions() { void TranslateBubbleView::ConfirmAdvancedOptions() {
model_->SetAlwaysTranslate(should_always_translate_); model_->SetAlwaysTranslate(should_always_translate_);
if (bubble_ui_model_ == language::TranslateUIBubbleModel::TAB) { if (bubble_ui_model_ == language::TranslateUIBubbleModel::TAB) {
// Switch back to the original page language if target language is the same if (model_->IsPageTranslatedInCurrentLanguages()) {
// as source language without triggering translating.
if (target_language_combobox_->GetSelectedIndex() ==
model_->GetOriginalLanguageIndex()) {
SwitchView(TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE);
tabbed_pane_->SelectTabAt(0);
ShowOriginal();
} else if (model_->IsPageTranslatedInCurrentLanguages()) {
SwitchView(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE); SwitchView(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE);
SizeToContents(); SizeToContents();
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment