Commit 2a145336 authored by Zentaro Kavanagh's avatar Zentaro Kavanagh Committed by Commit Bot

Mark classes with final dtors as final

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and remove warning exemption

Bug: 999886
Test: no errors building
Change-Id: I85c8b03f3dab773e5fb017acdcf0b6682f1c9e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466978
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816687}
parent c1c2cbae
......@@ -142,7 +142,8 @@ char* PrependHexAddress(char* output, const void* address) {
} // namespace
class SequenceManagerImpl::NativeWorkHandleImpl : public NativeWorkHandle {
class SequenceManagerImpl::NativeWorkHandleImpl final
: public NativeWorkHandle {
public:
NativeWorkHandleImpl(SequenceManagerImpl* sequence_manager,
TaskQueue::QueuePriority priority)
......
......@@ -282,7 +282,7 @@ class BASE_EXPORT TaskQueueImpl {
TaskQueueImpl* const outer_;
};
class TaskRunner : public SingleThreadTaskRunner {
class TaskRunner final : public SingleThreadTaskRunner {
public:
explicit TaskRunner(scoped_refptr<GuardedTaskPoster> task_poster,
scoped_refptr<AssociatedThreadId> associated_thread,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment