Commit 2a68be05 authored by dpapad's avatar dpapad Committed by Commit Bot

Disable more flaky SafetyTipPageInfoBubbleViewBrowserTest tests.

Specifically disabling:
 - LeaveSiteStillWarnsAfter
 - TimeOpenHistogram

These tests seem to rely on subtle timing of the NewTabPage initial
loading and are flaking on multiple platforms.

Bug: 1142769,1139955
Change-Id: I848acd8ac9c4bd65945cb5070a87ecea46b27885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502771
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: default avatarJoe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821793}
parent e877899b
......@@ -627,13 +627,9 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
// If the user clicks 'leave site', the warning should re-appear when the user
// re-visits the page.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC) || defined(OS_WIN)
#define MAYBE_LeaveSiteStillWarnsAfter DISABLED_LeaveSiteStillWarnsAfter
#else
#define MAYBE_LeaveSiteStillWarnsAfter LeaveSiteStillWarnsAfter
#endif
// Flaky in general, test depends on subtle timing, https://crbug.com/1142769
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
MAYBE_LeaveSiteStillWarnsAfter) {
DISABLED_LeaveSiteStillWarnsAfter) {
auto kNavigatedUrl = GetURL("site1.com");
if (!IsSuspiciousSiteWarningEnabled()) {
......@@ -1021,13 +1017,9 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
// Tests that the histograms recording how long the Safety Tip is open are
// recorded properly.
// Flaky on Mac: https://crbug.com/1139955
#if defined(OS_MAC)
#define MAYBE_TimeOpenHistogram DISABLED_TimeOpenHistogram
#else
#define MAYBE_TimeOpenHistogram TimeOpenHistogram
#endif
// Flaky in general, test depends on subtle timing, https://crbug.com/1142769
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
MAYBE_TimeOpenHistogram) {
DISABLED_TimeOpenHistogram) {
if (!IsSuspiciousSiteWarningEnabled()) {
return;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment