Surface Synchronization: Delete OnSurfaceCreated

Now that we don't do temporary reference ownership,
SurfaceObserver::OnSurfaceCreated doesn't do anything useful.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6e9cf4557c10f50f097cd02c78fb3bd688cfc9d6
Reviewed-on: https://chromium-review.googlesource.com/c/1291216Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601181}

components/viz/service/display/display_scheduler.cc

@@ -306,8 +306,6 @@ void DisplayScheduler::OnBeginFrameSourcePausedChanged(bool paused) {
     NOTIMPLEMENTED();
 }
 
-void DisplayScheduler::OnSurfaceCreated(const SurfaceId& surface_id) {}
-
 void DisplayScheduler::OnFirstSurfaceActivation(
     const SurfaceInfo& surface_info) {}
 

components/viz/service/display/display_scheduler.h

@@ -77,7 +77,6 @@ class VIZ_SERVICE_EXPORT DisplayScheduler : public BeginFrameObserverBase,
   void OnBeginFrameSourcePausedChanged(bool paused) override;
 
   // SurfaceObserver implementation.
-  void OnSurfaceCreated(const SurfaceId& surface_id) override;
   void OnFirstSurfaceActivation(const SurfaceInfo& surface_info) override;
   void OnSurfaceActivated(const SurfaceId& surface_id,
                           base::Optional<base::TimeDelta> duration) override;

components/viz/service/frame_sinks/frame_sink_manager_impl.cc

@@ -280,9 +280,6 @@ void FrameSinkManagerImpl::RequestCopyOfOutput(
                                   std::move(request));
 }
 
-void FrameSinkManagerImpl::OnSurfaceCreated(const SurfaceId& surface_id) {
-}
-
 void FrameSinkManagerImpl::OnFirstSurfaceActivation(
     const SurfaceInfo& surface_info) {
   DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);

components/viz/service/frame_sinks/frame_sink_manager_impl.h

@@ -106,7 +106,6 @@ class VIZ_SERVICE_EXPORT FrameSinkManagerImpl
                            std::unique_ptr<CopyOutputRequest> request) override;
 
   // SurfaceObserver implementation.
-  void OnSurfaceCreated(const SurfaceId& surface_id) override;
   void OnFirstSurfaceActivation(const SurfaceInfo& surface_info) override;
   void OnSurfaceActivated(const SurfaceId& surface_id,
                           base::Optional<base::TimeDelta> duration) override;

components/viz/service/frame_sinks/video_detector.h

@@ -73,7 +73,6 @@ class VIZ_SERVICE_EXPORT VideoDetector : public SurfaceObserver {
   void OnVideoActivityEnded();
 
   // SurfaceObserver implementation.
-  void OnSurfaceCreated(const SurfaceId& surface_id) override {}
   void OnFirstSurfaceActivation(const SurfaceInfo& surface_info) override {}
   void OnSurfaceActivated(const SurfaceId& surface_id,
                           base::Optional<base::TimeDelta> duration) override {}

components/viz/service/hit_test/hit_test_manager.h

@@ -25,7 +25,6 @@ class VIZ_SERVICE_EXPORT HitTestManager : public SurfaceObserver {
   virtual ~HitTestManager();
 
   // SurfaceObserver:
-  void OnSurfaceCreated(const SurfaceId& surface_id) override {}
   void OnFirstSurfaceActivation(const SurfaceInfo& surface_info) override {}
   void OnSurfaceActivated(const SurfaceId& surface_id,
                           base::Optional<base::TimeDelta> duration) override;

components/viz/service/surfaces/surface_manager.cc

@@ -126,8 +126,6 @@ Surface* SurfaceManager::CreateSurface(
     // is received, is added to prevent this from happening.
     AddTemporaryReference(surface_info.id());
 
-    for (auto& observer : observer_list_)
-      observer.OnSurfaceCreated(surface_info.id());
     return surface_map_[surface_info.id()].get();
   }
 
@@ -141,8 +139,6 @@ Surface* SurfaceManager::CreateSurface(
   surfaces_to_destroy_.erase(surface_info.id());
   SurfaceDiscarded(surface);
   surface->Reset(surface_client);
-  for (auto& observer : observer_list_)
-    observer.OnSurfaceCreated(surface_info.id());
   return surface;
 }
 

components/viz/service/surfaces/surface_observer.h

@@ -18,9 +18,6 @@ struct BeginFrameArgs;
 
 class SurfaceObserver {
  public:
-  // Called when a Surface with a new SurfaceId is created.
-  virtual void OnSurfaceCreated(const SurfaceId& surface_id) = 0;
-
   // Called when a CompositorFrame with a new SurfaceId activates for the first
   // time.
   virtual void OnFirstSurfaceActivation(const SurfaceInfo& surface_info) = 0;

components/viz/test/fake_surface_observer.h

@@ -36,7 +36,6 @@ class FakeSurfaceObserver : public SurfaceObserver {
 
  private:
   // SurfaceObserver implementation:
-  void OnSurfaceCreated(const SurfaceId& surface_id) override {}
   bool OnSurfaceDamaged(const SurfaceId& surface_id,
                         const BeginFrameAck& ack) override;
   void OnFirstSurfaceActivation(const SurfaceInfo& surface_info) override;