Commit 2a8b1539 authored by Shimi Zhang's avatar Shimi Zhang Committed by Commit Bot

Fix few lint errors

- android.view.View#getRootWindowInsets requires API level 23
- android.view.WindowInsets requires API level 20
- android.view.View#setOnApplyWindowInsetsListener requires API level 20

I am adding @TargetApi(Build.VERSION_CODES.O) for these places, assuming
that this file is added for Android Q and above, but our lint tool
doesn't recognize Build.VERSION_CODES higher than O...


Bug: None
Change-Id: Ib276a793706a3e1bf2231a6aa451d4b1a2ff7180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725212Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682472}
parent e70fe8b7
......@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.gesturenav;
import android.annotation.TargetApi;
import android.os.Build;
import android.view.View;
import android.view.WindowInsets;
......@@ -56,6 +57,7 @@ public class HistoryNavigationDelegateFactory {
return new TabbedActionDelegate(tab);
}
@TargetApi(Build.VERSION_CODES.O)
@Override
public boolean isNavigationEnabled(View view) {
if (!BuildInfo.isAtLeastQ() || Build.VERSION.SDK_INT <= Build.VERSION_CODES.P) {
......@@ -68,9 +70,10 @@ public class HistoryNavigationDelegateFactory {
/**
* @return {@link android.graphics.Insets} object.
*/
@TargetApi(Build.VERSION_CODES.O)
private Object getSystemGestureInsets(Object windowInsets) {
if (!BuildInfo.isAtLeastQ() || Build.VERSION.SDK_INT <= Build.VERSION_CODES.P) {
return true;
return null;
}
try {
Method method = WindowInsets.class.getMethod("getSystemGestureInsets");
......@@ -95,6 +98,7 @@ public class HistoryNavigationDelegateFactory {
return 0;
}
@TargetApi(Build.VERSION_CODES.O)
@Override
public void setWindowInsetsChangeObserver(View view, Runnable runnable) {
if (!BuildInfo.isAtLeastQ() || Build.VERSION.SDK_INT <= Build.VERSION_CODES.P) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment