Commit 2aa39598 authored by hcarmona's avatar hcarmona Committed by Commit bot

MD Settings: make iron list offset so items render onscreen

R=dbeam@chromium.org
BUG=689356
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805213003
Cr-Commit-Position: refs/heads/master@{#463312}
parent 8b7a7716
...@@ -46,7 +46,8 @@ ...@@ -46,7 +46,8 @@
</div> </div>
<div id="container" class="scroll-container"> <div id="container" class="scroll-container">
<iron-list items="[[engines]]" scroll-target="[[scrollTarget]]" <iron-list items="[[engines]]" scroll-target="[[scrollTarget]]"
class$="[[getIronListClass_(scrollTarget)]]"> class$="[[getIronListClass_(scrollTarget)]]"
scroll-offset="[[scrollOffset]]">
<template> <template>
<settings-search-engine-entry engine="[[item]]" <settings-search-engine-entry engine="[[item]]"
tabindex$="[[tabIndex]]" iron-list-tab-index="[[tabIndex]]" tabindex$="[[tabIndex]]" iron-list-tab-index="[[tabIndex]]"
......
...@@ -25,6 +25,9 @@ Polymer({ ...@@ -25,6 +25,9 @@ Polymer({
value: null, // Required to populate class. value: null, // Required to populate class.
}, },
/** Used to fix scrolling glitch when list is not top most element. */
scrollOffset: Number,
/** @private {Object}*/ /** @private {Object}*/
lastFocused_: Object, lastFocused_: Object,
}, },
......
...@@ -41,8 +41,8 @@ ...@@ -41,8 +41,8 @@
<div id="noOtherEngines" hidden="[[otherEngines.length]]"> <div id="noOtherEngines" hidden="[[otherEngines.length]]">
$i18n{searchEnginesNoOtherEngines} $i18n{searchEnginesNoOtherEngines}
</div> </div>
<settings-search-engines-list engines="[[otherEngines]]" hide-headers <settings-search-engines-list id="otherEngines" engines="[[otherEngines]]"
scroll-target="[[subpageScrollTarget]]"> hide-headers scroll-target="[[subpageScrollTarget]]">
</settings-search-engines-list> </settings-search-engines-list>
<template is="dom-if" if="[[showExtensionsList_]]"> <template is="dom-if" if="[[showExtensionsList_]]">
<div class="settings-box first"> <div class="settings-box first">
......
...@@ -59,6 +59,11 @@ Polymer({ ...@@ -59,6 +59,11 @@ Polymer({
getSearchEnginesList().then(this.enginesChanged_.bind(this)); getSearchEnginesList().then(this.enginesChanged_.bind(this));
this.addWebUIListener( this.addWebUIListener(
'search-engines-changed', this.enginesChanged_.bind(this)); 'search-engines-changed', this.enginesChanged_.bind(this));
// Sets offset in iron-list that uses the page as a scrollTarget.
Polymer.RenderStatus.afterNextRender(this, function() {
this.$.otherEngines.scrollOffset = this.$.otherEngines.offsetTop;
});
}, },
/** @private */ /** @private */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment