fix: disable kPlugin helper when enable_plugins=false

Bug: none
Change-Id: Iace766c61a64987fa4c25a12b0a74b3ec09d2c60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173416
Auto-Submit: Deepak Mohan <hop2deep@gmail.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765333}

content/common/child_process_host_impl.cc

@@ -32,6 +32,7 @@
 #include "ipc/ipc_logging.h"
 #include "ipc/message_filter.h"
 #include "mojo/public/cpp/bindings/lib/message_quota_checker.h"
+#include "ppapi/buildflags/buildflags.h"
 #include "services/resource_coordinator/public/mojom/memory_instrumentation/constants.mojom.h"
 #include "services/service_manager/public/cpp/interface_provider.h"
 
@@ -95,8 +96,10 @@ base::FilePath ChildProcessHost::GetChildPath(int flags) {
       child_base_name += kMacHelperSuffix_renderer;
     } else if (flags == CHILD_GPU) {
       child_base_name += kMacHelperSuffix_gpu;
+#if BUILDFLAG(ENABLE_PLUGINS)
     } else if (flags == CHILD_PLUGIN) {
       child_base_name += kMacHelperSuffix_plugin;
+#endif
     } else {
       NOTREACHED();
     }

content/public/app/mac_helpers.gni

@@ -2,6 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//ppapi/buildflags/buildflags.gni")
+
 # This list defines variants of the helper app bundles that macOS //content
 # embedders need to produce. The different variants are code signed with
 # different entitlements, which afford different capabilities depending on the
@@ -45,13 +47,17 @@ content_mac_helpers = [
     "",
     " (GPU)",
   ],
-
-  # A helper that does not perform library validation, allowing code not signed
-  # by either Apple or the signing identity to be loaded, and that can execute
-  # unsigned memory. This is used by binary plugins like Flash.
-  [
-    "plugin",
-    ".plugin",
-    " (Plugin)",
-  ],
 ]
+
+if (enable_plugins) {
+  content_mac_helpers += [
+    # A helper that does not perform library validation, allowing code not signed
+    # by either Apple or the signing identity to be loaded, and that can execute
+    # unsigned memory. This is used by binary plugins like Flash.
+    [
+      "plugin",
+      ".plugin",
+      " (Plugin)",
+    ],
+  ]
+}