Tests for Add Credit Card View fields

- Enables CreditCardScanner feature flag in setup.
- Tests text fields appear - name, card number, expiry month, expiry year.
- Tests 'Use Camera' button appears only in iOS 13.

Bug:1000669

Change-Id: Idf4d39061b715bab322e88b65ccc2d31e715bb98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787378Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Cr-Commit-Position: refs/heads/master@{#695080}

ios/chrome/browser/ui/settings/autofill/BUILD.gn

@@ -125,13 +125,13 @@ source_set("eg2_tests") {
     "//build/config/ios:xctest_config",
   ]
   testonly = true
-
   sources = [
     "autofill_add_credit_card_egtest.mm",
   ]
-
   deps = [
     ":feature_flags",
+    "//base",
+    "//ios/chrome/app/strings",
     "//ios/chrome/test/earl_grey:eg_test_support+eg2",
     "//ios/testing/earl_grey:eg_test_support+eg2",
     "//ios/third_party/earl_grey2:test_lib",
@@ -139,6 +139,5 @@ source_set("eg2_tests") {
     "//net:test_support",
     "//ui/base",
   ]
-
   libs = [ "UIKit.framework" ]
 }

ios/chrome/browser/ui/settings/autofill/autofill_add_credit_card_egtest.mm

@@ -3,20 +3,57 @@
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/autofill/features.h"
+#include "ios/chrome/grit/ios_strings.h"
 #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
 #import "ios/chrome/test/earl_grey/chrome_earl_grey_ui.h"
 #import "ios/chrome/test/earl_grey/chrome_matchers.h"
 #import "ios/chrome/test/earl_grey/chrome_test_case.h"
 #import "ios/testing/earl_grey/app_launch_manager.h"
 #import "ios/testing/earl_grey/earl_grey_test.h"
+#include "ui/base/l10n/l10n_util_mac.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 using chrome_test_util::AddPaymentMethodButton;
+using chrome_test_util::ButtonWithAccessibilityLabelId;
 using chrome_test_util::PaymentMethodsButton;
 
+namespace {
+
+// Matcher for the 'Name on Card' field in the add credit card view.
+id<GREYMatcher> NameOnCardField() {
+  return grey_accessibilityLabel(
+      l10n_util::GetNSStringWithFixup(IDS_IOS_AUTOFILL_CARDHOLDER));
+}
+
+// Matcher for the 'Card Number' field in the add credit card view.
+id<GREYMatcher> CardNumberField() {
+  return grey_accessibilityLabel(
+      l10n_util::GetNSStringWithFixup(IDS_IOS_AUTOFILL_CARD_NUMBER));
+}
+
+// Matcher for the 'Month of Expiry' field in the add credit card view.
+id<GREYMatcher> MonthOfExpiryField() {
+  return grey_accessibilityLabel(
+      l10n_util::GetNSStringWithFixup(IDS_IOS_AUTOFILL_EXP_MONTH));
+}
+
+// Matcher for the 'Year of Expiry' field in the add credit card view.
+id<GREYMatcher> YearOfExpiryField() {
+  return grey_accessibilityLabel(
+      l10n_util::GetNSStringWithFixup(IDS_IOS_AUTOFILL_EXP_YEAR));
+}
+
+// Matcher for the use camera button in the add credit card view.
+id<GREYMatcher> UseCameraButton() {
+  return ButtonWithAccessibilityLabelId(
+      IDS_IOS_AUTOFILL_ADD_CREDIT_CARD_OPEN_CAMERA_BUTTON_LABEL);
+}
+
+}  // namespace
+
 // Tests for Settings Autofill add credit cards section.
 @interface AutofillAddCreditCardTestCase : ChromeTestCase
 @end
@@ -26,11 +63,14 @@ using chrome_test_util::PaymentMethodsButton;
 - (void)setUp {
   [super setUp];
   [[AppLaunchManager sharedManager]
-      ensureAppLaunchedWithFeaturesEnabled:{kSettingsAddPaymentMethod}
+      ensureAppLaunchedWithFeaturesEnabled:{kSettingsAddPaymentMethod,
+                                            kCreditCardScanner}
                                   disabled:{}
                               forceRestart:NO];
   GREYAssertTrue([ChromeEarlGrey isSettingsAddPaymentMethodEnabled],
                  @"SettingsAddPaymentMethod should be enabled");
+  GREYAssertTrue([ChromeEarlGrey isCreditCardScannerEnabled],
+                 @"CreditCardScanner should be enabled");
   [ChromeEarlGrey openNewTab];
   [ChromeEarlGreyUI openSettingsMenu];
   [ChromeEarlGreyUI tapSettingsMenuButton:PaymentMethodsButton()];
@@ -38,4 +78,41 @@ using chrome_test_util::PaymentMethodsButton;
       performAction:grey_tap()];
 }
 
+#pragma mark - Test that all fields on the 'Add Credit Card' screen appear
+
+// Tests that 'Name on Card' field appears on screen.
+- (void)testNameOnCardFieldIsPresent {
+  [[EarlGrey selectElementWithMatcher:NameOnCardField()]
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
+// Tests that 'Card Number' field appears on screen.
+- (void)testCardNumberFieldIsPresent {
+  [[EarlGrey selectElementWithMatcher:CardNumberField()]
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
+// Tests that 'Month of Expiry' field appears on screen.
+- (void)testMonthOfExpiryFieldIsPresent {
+  [[EarlGrey selectElementWithMatcher:MonthOfExpiryField()]
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
+// Tests that 'Year of Expiry' field appears on screen.
+- (void)testYearOfExpiryFieldIsPresent {
+  [[EarlGrey selectElementWithMatcher:YearOfExpiryField()]
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
+// Tests that 'Use Camera' button appears on screen only for iOS 13.
+- (void)testUseCameraButtonIsPresent {
+  if (@available(iOS 13, *)) {
+    [[EarlGrey selectElementWithMatcher:UseCameraButton()]
+        assertWithMatcher:grey_sufficientlyVisible()];
+  } else {
+    [[EarlGrey selectElementWithMatcher:UseCameraButton()]
+        assertWithMatcher:grey_nil()];
+  }
+}
+
 @end

ios/chrome/browser/ui/settings/autofill/autofill_add_credit_card_view_controller.mm

@@ -178,6 +178,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
   cameraButtonItem.text = l10n_util::GetNSString(
       IDS_IOS_AUTOFILL_ADD_CREDIT_CARD_OPEN_CAMERA_BUTTON_LABEL);
   cameraButtonItem.textAlignment = NSTextAlignmentCenter;
+  cameraButtonItem.accessibilityTraits |= UIAccessibilityTraitButton;
   if (base::FeatureList::IsEnabled(kCreditCardScanner)) {
     if (@available(iOS 13, *)) {
       [model addSectionWithIdentifier:SectionIdentifierCameraButton];

ios/chrome/test/earl_grey/chrome_earl_grey.h

@@ -372,6 +372,9 @@ id ExecuteJavaScript(NSString* javascript, NSError* __autoreleasing* out_error);
 // Returns YES if SettingsAddPaymentMethod feature is enabled.
 - (BOOL)isSettingsAddPaymentMethodEnabled WARN_UNUSED_RESULT;
 
+// Returns YES if CreditCardScanner feature is enabled.
+- (BOOL)isCreditCardScannerEnabled WARN_UNUSED_RESULT;
+
 #pragma mark - Popup Blocking
 
 // Gets the current value of the popup content setting preference for the

ios/chrome/test/earl_grey/chrome_earl_grey.mm

@@ -622,6 +622,10 @@ GREY_STUB_CLASS_IN_APP_MAIN_QUEUE(ChromeEarlGreyAppInterface)
   return [ChromeEarlGreyAppInterface isSettingsAddPaymentMethodEnabled];
 }
 
+- (BOOL)isCreditCardScannerEnabled {
+  return [ChromeEarlGreyAppInterface isCreditCardScannerEnabled];
+}
+
 #pragma mark - ScopedBlockPopupsPref
 
 - (ContentSetting)popupPrefValue {

ios/chrome/test/earl_grey/chrome_earl_grey_app_interface.h

@@ -305,6 +305,9 @@
 // Returns YES if SettingsAddPaymentMethod feature is enabled.
 + (BOOL)isSettingsAddPaymentMethodEnabled WARN_UNUSED_RESULT;
 
+// Returns YES if CreditCardScanner feature is enabled.
++ (BOOL)isCreditCardScannerEnabled WARN_UNUSED_RESULT;
+
 #pragma mark - Popup Blocking
 
 // Gets the current value of the popup content setting preference for the

ios/chrome/test/earl_grey/chrome_earl_grey_app_interface.mm

@@ -520,6 +520,10 @@ using chrome_test_util::BrowserCommandDispatcherForMainBVC;
   return base::FeatureList::IsEnabled(kSettingsAddPaymentMethod);
 }
 
++ (BOOL)isCreditCardScannerEnabled {
+  return base::FeatureList::IsEnabled(kCreditCardScanner);
+}
+
 #pragma mark - ScopedBlockPopupsPref
 
 + (ContentSetting)popupPrefValue {