apple: Convert GN libs lists to frameworks in //remoting.

GN recently added support for Apple frameworks to link, rather than
overloading the libs lists. This pulls .frameworks out of the libs
lists, so that GN can stop supporting .frameworks in libs in the
future.

Bug: 1052560
Change-Id: Ifa946ad268b0197368d6f9694a69976eb14d752a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276817
Auto-Submit: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784256}

remoting/client/display/BUILD.gn

@@ -48,11 +48,11 @@ source_set("display") {
   }
 
   if (is_mac) {
-    libs = [ "OpenGL.framework" ]
+    frameworks = [ "OpenGL.framework" ]
   }
 
   if (is_ios) {
-    libs = [
+    frameworks = [
       "GLKit.framework",
       "OpenGLES.framework",
     ]

remoting/host/file_transfer/BUILD.gn

@@ -27,7 +27,7 @@ source_set("file_transfer") {
   ]
 
   if (is_mac) {
-    libs = [ "AppKit.framework" ]
+    frameworks = [ "AppKit.framework" ]
   }
 
   if (!is_mac && !is_win) {

remoting/host/installer/mac/BUILD.gn

@@ -124,7 +124,7 @@ mac_app_bundle("remoting_host_uninstaller") {
     "uninstaller/remoting_uninstaller_app.mm",
   ]
 
-  libs = [
+  frameworks = [
     "Cocoa.framework",
     "CoreFoundation.framework",
     "Security.framework",

remoting/ios/BUILD.gn

@@ -40,7 +40,7 @@ source_set("ios_core") {
     "//remoting/protocol",
   ]
 
-  libs = [
+  frameworks = [
     "CoreGraphics.framework",
     "GLKit.framework",
     "OpenGLES.framework",

remoting/ios/app/BUILD.gn

@@ -96,7 +96,7 @@ source_set("common_source_set") {
     "//ui/resources",
   ]
 
-  libs = [
+  frameworks = [
     "UIKit.framework",
     "AVFoundation.framework",
     "Foundation.framework",
@@ -131,7 +131,7 @@ source_set("app_source_set") {
     ":common_source_set",
     "//base",
   ]
-  libs = [ "UIKit.framework" ]
+  frameworks = [ "UIKit.framework" ]
 
   # TODO(crbug.com/875022) fix for OpenGLES deprecation.
   defines = [ "GLES_SILENCE_DEPRECATION" ]

remoting/ios/app/remoting_ios_tmpl.gni

@@ -88,7 +88,7 @@ template("ios_remoting_app_tmpl") {
       "VERSION_SHORT=$remoting_version_short",
     ]
 
-    libs = [
+    frameworks = [
       "Accelerate.framework",
       "AudioToolbox.framework",
       "CoreAudio.framework",

remoting/ios/audio/BUILD.gn

@@ -20,7 +20,7 @@ source_set("audio") {
 
   public_deps = [ "//remoting/proto" ]
 
-  libs = [ "AudioToolbox.framework" ]
+  frameworks = [ "AudioToolbox.framework" ]
 
   configs += [ "//build/config/compiler:enable_arc" ]
 }

remoting/ios/display/BUILD.gn

@@ -37,7 +37,7 @@ source_set("display") {
 
   include_dirs = [ "//third_party/protobuf/src" ]
 
-  libs = [
+  frameworks = [
     "CoreGraphics.framework",
     "GLKit.framework",
     "OpenGLES.framework",

remoting/ios/facade/BUILD.gn

@@ -36,7 +36,7 @@ source_set("facade") {
     "//ui/base",
   ]
 
-  libs = [ "CoreFoundation.framework" ]
+  frameworks = [ "CoreFoundation.framework" ]
 
   public_deps = [
     "//remoting/base",

remoting/ios/mdc/BUILD.gn

@@ -12,7 +12,7 @@ source_set("mdc") {
     "MDCActionImageView.m",
   ]
 
-  libs = [ "UIKit.framework" ]
+  frameworks = [ "UIKit.framework" ]
 
   deps = [ "//ios/third_party/material_components_ios" ]
 

remoting/ios/persistence/BUILD.gn

@@ -53,7 +53,7 @@ source_set("unit_tests") {
     "//testing/gtest",
   ]
 
-  libs = [ "Security.framework" ]
+  frameworks = [ "Security.framework" ]
 
   configs += [ "//build/config/compiler:enable_arc" ]
 }

remoting/ios/session/BUILD.gn

@@ -25,7 +25,7 @@ source_set("session") {
     "//remoting/protocol",
   ]
 
-  libs = [ "CoreGraphics.framework" ]
+  frameworks = [ "CoreGraphics.framework" ]
 
   configs += [ "//build/config/compiler:enable_arc" ]
 }