Commit 2b266398 authored by Takumi Fujimoto's avatar Takumi Fujimoto Committed by Commit Bot

Disable flaky Java tests

Disable tests that were determined by Findit to be flaky.

TBR=bsazonov,szermatt

Bug: 1030217, 1030559, 1030561, 1030683, 1030903, 1030562, 1030558, 1030218
Change-Id: If58bf930e3963dadac6682cab38674f30fee1efe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951894Reviewed-by: default avatarTakumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721778}
parent ca15510a
...@@ -45,6 +45,7 @@ import org.junit.runner.RunWith; ...@@ -45,6 +45,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.LocaleUtils; import org.chromium.base.LocaleUtils;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.chrome.autofill_assistant.R; import org.chromium.chrome.autofill_assistant.R;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.autofill.CardType; import org.chromium.chrome.browser.autofill.CardType;
...@@ -551,6 +552,7 @@ public class AutofillAssistantCollectUserDataUiTest { ...@@ -551,6 +552,7 @@ public class AutofillAssistantCollectUserDataUiTest {
*/ */
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "Flaky. crbug.com/1030217")
public void testNonEmptyPaymentRequest() throws Exception { public void testNonEmptyPaymentRequest() throws Exception {
/* Add complete profile and credit card to the personal data manager. */ /* Add complete profile and credit card to the personal data manager. */
PersonalDataManager.AutofillProfile profile = PersonalDataManager.AutofillProfile profile =
......
...@@ -301,6 +301,7 @@ public class AutofillPopupTest { ...@@ -301,6 +301,7 @@ public class AutofillPopupTest {
@Test @Test
@MediumTest @MediumTest
@Feature({"autofill"}) @Feature({"autofill"})
@DisabledTest(message = "Flaky. crbug.com/1030559")
public void testLoggingAnotherElementFilled() throws TimeoutException { public void testLoggingAnotherElementFilled() throws TimeoutException {
loadAndFillForm(ANOTHER_ELEMENT_FILLED, "J"); loadAndFillForm(ANOTHER_ELEMENT_FILLED, "J");
final String profileFullName = FIRST_NAME + " " + LAST_NAME; final String profileFullName = FIRST_NAME + " " + LAST_NAME;
......
...@@ -31,6 +31,7 @@ import org.chromium.base.test.params.ParameterizedRunner; ...@@ -31,6 +31,7 @@ import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf; import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest; import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
...@@ -449,6 +450,7 @@ public class BookmarkTest { ...@@ -449,6 +450,7 @@ public class BookmarkTest {
@MediumTest @MediumTest
@Feature({"RenderTest"}) @Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "Flaky. crbug.com/1030561")
public void testBookmarkFolderIcon(boolean nightModeEnabled) throws Exception { public void testBookmarkFolderIcon(boolean nightModeEnabled) throws Exception {
BookmarkPromoHeader.forcePromoStateForTests(BookmarkPromoHeader.PromoState.PROMO_NONE); BookmarkPromoHeader.forcePromoStateForTests(BookmarkPromoHeader.PromoState.PROMO_NONE);
BookmarkId testId = addFolder(TEST_FOLDER_TITLE); BookmarkId testId = addFolder(TEST_FOLDER_TITLE);
......
...@@ -38,6 +38,7 @@ import org.junit.runner.RunWith; ...@@ -38,6 +38,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.ThreadUtils; import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction; import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.R; import org.chromium.chrome.R;
...@@ -267,6 +268,7 @@ public class TabModalPresenterTest { ...@@ -267,6 +268,7 @@ public class TabModalPresenterTest {
@SmallTest @SmallTest
@Feature({"ModalDialog"}) @Feature({"ModalDialog"})
@Restriction(UiRestriction.RESTRICTION_TYPE_PHONE) @Restriction(UiRestriction.RESTRICTION_TYPE_PHONE)
@DisabledTest(message = "Flaky. crbug.com/1030683")
public void testSuspend_TabClosed() throws Exception { public void testSuspend_TabClosed() throws Exception {
PropertyModel dialog1 = createDialog(mActivity, "1", null); PropertyModel dialog1 = createDialog(mActivity, "1", null);
PropertyModel dialog2 = createDialog(mActivity, "2", null); PropertyModel dialog2 = createDialog(mActivity, "2", null);
...@@ -320,6 +322,7 @@ public class TabModalPresenterTest { ...@@ -320,6 +322,7 @@ public class TabModalPresenterTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"ModalDialog"}) @Feature({"ModalDialog"})
@DisabledTest(message = "Flaky. crbug.com/1030903")
public void testDismiss_SwitchTab() throws Exception { public void testDismiss_SwitchTab() throws Exception {
PropertyModel dialog1 = createDialog(mActivity, "1", null); PropertyModel dialog1 = createDialog(mActivity, "1", null);
PropertyModel dialog2 = createDialog(mActivity, "2", null); PropertyModel dialog2 = createDialog(mActivity, "2", null);
......
...@@ -35,6 +35,7 @@ import org.chromium.base.task.PostTask; ...@@ -35,6 +35,7 @@ import org.chromium.base.task.PostTask;
import org.chromium.base.test.params.ParameterAnnotations; import org.chromium.base.test.params.ParameterAnnotations;
import org.chromium.base.test.params.ParameterizedRunner; import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils; import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.R; import org.chromium.chrome.R;
...@@ -179,6 +180,7 @@ public class ArticleSnippetsTest { ...@@ -179,6 +180,7 @@ public class ArticleSnippetsTest {
@MediumTest @MediumTest
@Feature({"ArticleSnippets", "RenderTest"}) @Feature({"ArticleSnippets", "RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class) @ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "Flaky. crbug.com/1030562")
public void testSnippetAppearance(boolean nightModeEnabled) throws IOException { public void testSnippetAppearance(boolean nightModeEnabled) throws IOException {
SuggestionsCategoryInfo fullCategoryInfo = new SuggestionsCategoryInfo(FULL_CATEGORY, SuggestionsCategoryInfo fullCategoryInfo = new SuggestionsCategoryInfo(FULL_CATEGORY,
"Section Title", ContentSuggestionsCardLayout.FULL_CARD, "Section Title", ContentSuggestionsCardLayout.FULL_CARD,
......
...@@ -15,6 +15,7 @@ import org.junit.Test; ...@@ -15,6 +15,7 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.RetryOnFailure; import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.base.test.util.UrlUtils; import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
...@@ -118,6 +119,7 @@ public class MHTMLPageTest implements CustomMainActivityStart { ...@@ -118,6 +119,7 @@ public class MHTMLPageTest implements CustomMainActivityStart {
@Test @Test
@SmallTest @SmallTest
@RetryOnFailure @RetryOnFailure
@DisabledTest(message = "Flaky. crbug.com/1030558")
public void testDownloadMultipartRelatedPageFromServer() throws Exception { public void testDownloadMultipartRelatedPageFromServer() throws Exception {
// .mhtml file is mapped to "multipart/related" by the test server. // .mhtml file is mapped to "multipart/related" by the test server.
final String url = mTestServer.getURL("/chrome/test/data/android/hello.mhtml"); final String url = mTestServer.getURL("/chrome/test/data/android/hello.mhtml");
......
...@@ -451,6 +451,7 @@ public class SiteSettingsPreferencesTest { ...@@ -451,6 +451,7 @@ public class SiteSettingsPreferencesTest {
@SmallTest @SmallTest
@Feature({"Preferences"}) @Feature({"Preferences"})
@EnableFeatures("QuietNotificationPrompts") @EnableFeatures("QuietNotificationPrompts")
@DisabledTest(message = "Flaky. crbug.com/1030218")
public void testOnlyExpectedPreferencesShown() { public void testOnlyExpectedPreferencesShown() {
// If you add a category in the SiteSettings UI, please add a test for it below. // If you add a category in the SiteSettings UI, please add a test for it below.
Assert.assertEquals(19, SiteSettingsCategory.Type.NUM_ENTRIES); Assert.assertEquals(19, SiteSettingsCategory.Type.NUM_ENTRIES);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment