Reland "Add unittests for AudioOutputStream."

This is a reland of eec981f1
Original change's description:
> Add unittests for AudioOutputStream.
> 
> Previosly there were no cross-platforms tests for AudioOutputStream.
> This CL adds new tests that will run on all platforms. The tests
> are based on Windows-specific tests in media/audio/win.
> 
> Bug: 737802
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6
> Reviewed-on: https://chromium-review.googlesource.com/702688
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509522}

Bug: 737802
Change-Id: Ia3b7953437b484f37a339a90e3db9af1f315bdd9
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/809540Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522245}

media/audio/BUILD.gn

@@ -376,6 +376,7 @@ source_set("unit_tests") {
     "audio_output_controller_unittest.cc",
     "audio_output_device_unittest.cc",
     "audio_output_proxy_unittest.cc",
+    "audio_output_unittest.cc",
     "audio_power_monitor_unittest.cc",
     "audio_system_impl_unittest.cc",
     "power_observer_helper_unittest.cc",

media/audio/audio_output_unittest.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <stdint.h>
+
+#include <memory>
+
+#include "base/memory/aligned_memory.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
+#include "media/audio/audio_device_info_accessor_for_tests.h"
+#include "media/audio/audio_io.h"
+#include "media/audio/audio_manager.h"
+#include "media/audio/audio_unittest_util.h"
+#include "media/audio/simple_sources.h"
+#include "media/audio/test_audio_thread.h"
+#include "media/base/limits.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media {
+
+class AudioOutputTest : public ::testing::Test {
+ public:
+  AudioOutputTest() {
+    audio_manager_ =
+        AudioManager::CreateForTesting(base::MakeUnique<TestAudioThread>());
+    audio_manager_device_info_ =
+        base::MakeUnique<AudioDeviceInfoAccessorForTests>(audio_manager_.get());
+    base::RunLoop().RunUntilIdle();
+  }
+  ~AudioOutputTest() override {
+    if (stream_)
+      stream_->Close();
+    audio_manager_->Shutdown();
+  }
+
+  void CreateWithDefaultParameters() {
+    stream_params_ =
+        audio_manager_device_info_->GetDefaultOutputStreamParameters();
+    stream_ = audio_manager_->MakeAudioOutputStream(
+        stream_params_, std::string(), AudioManager::LogCallback());
+  }
+
+  // Runs message loop for the specified amount of time.
+  void RunMessageLoop(base::TimeDelta delay) {
+    base::RunLoop run_loop;
+    base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+        FROM_HERE, run_loop.QuitClosure(), delay);
+    run_loop.Run();
+  }
+
+ protected:
+  base::MessageLoop message_loop_;
+  std::unique_ptr<AudioManager> audio_manager_;
+  std::unique_ptr<AudioDeviceInfoAccessorForTests> audio_manager_device_info_;
+  AudioParameters stream_params_;
+  AudioOutputStream* stream_ = nullptr;
+};
+
+// Test that can it be created and closed.
+TEST_F(AudioOutputTest, GetAndClose) {
+  ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
+  CreateWithDefaultParameters();
+  ASSERT_TRUE(stream_);
+}
+
+// Test that it can be opened and closed.
+TEST_F(AudioOutputTest, OpenAndClose) {
+  ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
+
+  CreateWithDefaultParameters();
+  ASSERT_TRUE(stream_);
+  EXPECT_TRUE(stream_->Open());
+}
+
+// This test produces actual audio for .25 seconds on the default device.
+TEST_F(AudioOutputTest, Play200HzTone) {
+  ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
+
+  stream_params_ =
+      audio_manager_device_info_->GetDefaultOutputStreamParameters();
+  stream_ = audio_manager_->MakeAudioOutputStream(stream_params_, std::string(),
+                                                  AudioManager::LogCallback());
+  ASSERT_TRUE(stream_);
+
+  SineWaveAudioSource source(1, 200.0, stream_params_.sample_rate());
+
+  EXPECT_TRUE(stream_->Open());
+  stream_->SetVolume(1.0);
+  stream_->Start(&source);
+  RunMessageLoop(base::TimeDelta::FromMilliseconds(250));
+  stream_->Stop();
+
+  EXPECT_FALSE(source.errors());
+  EXPECT_GE(source.callbacks(), 1);
+}
+
+// Test that SetVolume() and GetVolume() work as expected.
+TEST_F(AudioOutputTest, VolumeControl) {
+  ABORT_AUDIO_TEST_IF_NOT(audio_manager_device_info_->HasAudioOutputDevices());
+
+  CreateWithDefaultParameters();
+  ASSERT_TRUE(stream_);
+  EXPECT_TRUE(stream_->Open());
+
+  double volume = 0.0;
+
+  stream_->GetVolume(&volume);
+  EXPECT_EQ(volume, 1.0);
+
+  stream_->SetVolume(0.5);
+
+  stream_->GetVolume(&volume);
+  EXPECT_LT(volume, 0.51);
+  EXPECT_GT(volume, 0.49);
+  stream_->Stop();
+}
+
+}  // namespace media

media/audio/mac/audio_auhal_mac.cc

@@ -175,7 +175,6 @@ AUHALStream::AUHALStream(AudioManagerMac* manager,
   DCHECK(manager_);
   DCHECK(params_.IsValid());
   DCHECK_NE(device, kAudioObjectUnknown);
-  CHECK(!log_callback_.Equals(AudioManager::LogCallback()));
 }
 
 AUHALStream::~AUHALStream() {
@@ -409,10 +408,13 @@ void AUHALStream::ReportAndResetStats() {
                               1, 999999, 100);
 
   auto lost_frames_ms = (total_lost_frames_ * 1000) / params_.sample_rate();
+
   std::string log_message = base::StringPrintf(
       "AU out: Total glitches=%d. Total frames lost=%d (%d ms).",
       glitches_detected_, total_lost_frames_, lost_frames_ms);
-  log_callback_.Run(log_message);
+
+  if (!log_callback_.is_null())
+    log_callback_.Run(log_message);
 
   if (glitches_detected_ != 0) {
     UMA_HISTOGRAM_COUNTS("Media.Audio.Render.LostFramesInMs", lost_frames_ms);