Fast app reinstall: Remove first-time Chromebook user check

I created a syncable pref in crrev.com/c/1213521 to check if a user has
gone through OOBE before. Now that the server side will conduct the
check so the syncable pref is no longer necessary.

Please see b/114134918 for more details.

Bug: 835029
Change-Id: Iab53007458ecd4f42915571fba96c91b894625a5
Reviewed-on: https://chromium-review.googlesource.com/1252851
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595566}

chrome/browser/chromeos/login/wizard_controller.cc

@@ -275,14 +275,9 @@ bool NetworkAllowUpdate(const chromeos::NetworkState* network) {
   return true;
 }
 
-// Return true if the feature flag for recommend app screen is on and the screen
-// is never triggered before.
+// Return true if the feature flag for recommend app screen is on.
 bool ShouldShowRecommendAppsScreen() {
-  return base::FeatureList::IsEnabled(features::kOobeRecommendAppsScreen) &&
-         (!ProfileManager::GetActiveUserProfile()->GetPrefs()->GetBoolean(
-              prefs::kOobeRecommendAppScreenFinished) ||
-          base::CommandLine::ForCurrentProcess()->HasSwitch(
-              chromeos::switches::kForceShowRecommendAppsScreenForTest));
+  return base::FeatureList::IsEnabled(features::kOobeRecommendAppsScreen);
 }
 
 chromeos::LoginDisplayHost* GetLoginDisplayHost() {

chrome/browser/profiles/profile_impl.cc

@@ -422,9 +422,6 @@ void ProfileImpl::RegisterProfilePrefs(
   registry->RegisterIntegerPref(prefs::kPrintingColorDefault, 0);
   registry->RegisterIntegerPref(prefs::kPrintingDuplexDefault, 0);
   registry->RegisterDictionaryPref(prefs::kPrintingSizeDefault);
-  registry->RegisterBooleanPref(
-      prefs::kOobeRecommendAppScreenFinished, false,
-      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 #endif  // defined(OS_CHROMEOS)
 #endif  // BUILDFLAG(ENABLE_PRINTING)
   registry->RegisterBooleanPref(prefs::kPrintPreviewDisabled, false);

chrome/browser/ui/webui/chromeos/login/recommend_apps_screen_handler.cc

@@ -10,7 +10,6 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/app_list/arc/arc_fast_app_reinstall_starter.h"
-#include "chrome/common/pref_names.h"
 #include "chrome/grit/component_extension_resources.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/arc/arc_prefs.h"
@@ -125,8 +124,6 @@ void RecommendAppsScreenHandler::Show() {
 
   Profile* profile = ProfileManager::GetActiveUserProfile();
   pref_service_ = profile->GetPrefs();
-
-  profile->GetPrefs()->SetBoolean(prefs::kOobeRecommendAppScreenFinished, true);
 }
 
 void RecommendAppsScreenHandler::Hide() {}

chrome/common/pref_names.cc

@@ -1833,10 +1833,6 @@ const char kOobeScreenPending[] = "OobeScreenPending";
 // and get enrolled into a domain automatically.
 const char kOobeControllerDetected[] = "OobeControllerDetected";
 
-// A boolean pref to indicate if the Recommend App screen in OOBE is finished
-// for the user.
-const char kOobeRecommendAppScreenFinished[] = "OobeRecommendAppScreenFinished";
-
 // A boolean pref for whether the Goodies promotion webpage has been displayed,
 // or otherwise disqualified for auto-display, on this device.
 const char kCanShowOobeGoodiesPage[] = "CanShowOobeGoodiesPage";

chrome/common/pref_names.h

@@ -617,7 +617,6 @@ extern const char kInitialLocale[];
 extern const char kOobeComplete[];
 extern const char kOobeScreenPending[];
 extern const char kOobeControllerDetected[];
-extern const char kOobeRecommendAppScreenFinished[];
 extern const char kCanShowOobeGoodiesPage[];
 extern const char kDeviceRegistered[];
 extern const char kEnrollmentRecoveryRequired[];

chromeos/chromeos_switches.cc

@@ -437,11 +437,6 @@ const char kForceHappinessTrackingSystem[] = "force-happiness-tracking-system";
 // tests can change how it's brought up. This flag disables that.
 const char kForceLoginManagerInTests[] = "force-login-manager-in-tests";
 
-// Recommend-apps screen is only shown to first-time Chromebook users. This flag
-// skips the check so that testers can reuse the same accounts.
-const char kForceShowRecommendAppsScreenForTest[] =
-    "force-show-recommend-apps-screen-for-test";
-
 // Force system compositor mode when set.
 const char kForceSystemCompositorMode[] = "force-system-compositor-mode";
 

chromeos/chromeos_switches.h

@@ -124,7 +124,6 @@ CHROMEOS_EXPORT extern const char kForceDevToolsAvailable[];
 CHROMEOS_EXPORT extern const char kForceFirstRunUI[];
 CHROMEOS_EXPORT extern const char kForceHappinessTrackingSystem[];
 CHROMEOS_EXPORT extern const char kForceLoginManagerInTests[];
-CHROMEOS_EXPORT extern const char kForceShowRecommendAppsScreenForTest[];
 CHROMEOS_EXPORT extern const char kForceSystemCompositorMode[];
 CHROMEOS_EXPORT extern const char kGoldenScreenshotsDir[];
 CHROMEOS_EXPORT extern const char kGuestSession[];