borealis: Add unit tests for the installer

Added unit tests for the borealis installer logic.

Cq-Depend: 2391891
Tests: Ran tests
Bug: b:161650651
Change-Id: I708753a61e98be5b392c9559200c9b07b12b8dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392163
Commit-Queue: Daniel Ng <danielng@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#805173}

chrome/browser/chromeos/BUILD.gn

@@ -3114,6 +3114,7 @@ source_set("unit_tests") {
     "authpolicy/authpolicy_helper.unittest.cc",
     "base/file_flusher_unittest.cc",
     "bluetooth/debug_logs_manager_unittest.cc",
+    "borealis/borealis_installer_unittest.cc",
     "cert_provisioning/cert_provisioning_invalidator_unittest.cc",
     "cert_provisioning/cert_provisioning_platform_keys_helpers_unittest.cc",
     "cert_provisioning/cert_provisioning_scheduler_unittest.cc",

chrome/browser/chromeos/borealis/borealis_installer_unittest.cc

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/borealis/borealis_installer_impl.h"
+
+#include <memory>
+
+#include "base/test/scoped_feature_list.h"
+#include "chrome/browser/chromeos/borealis/borealis_installer_factory.h"
+#include "chrome/browser/chromeos/borealis/borealis_util.h"
+#include "chrome/common/chrome_features.h"
+#include "chrome/test/base/testing_profile.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/dlcservice/fake_dlcservice_client.h"
+#include "content/public/test/browser_task_environment.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace borealis {
+
+namespace {}  // namespace
+
+using ::testing::_;
+using ::testing::Mock;
+using ::testing::StrictMock;
+using InstallingState = BorealisInstaller::InstallingState;
+using InstallationResult = BorealisInstaller::InstallationResult;
+
+class MockObserver : public BorealisInstaller::Observer {
+ public:
+  MOCK_METHOD1(OnProgressUpdated, void(double));
+  MOCK_METHOD1(OnStateUpdated, void(InstallingState));
+  MOCK_METHOD1(OnInstallationEnded, void(InstallationResult));
+  MOCK_METHOD0(OnCancelInitiated, void());
+};
+
+class BorealisInstallerTest : public testing::Test {
+ public:
+  BorealisInstallerTest() = default;
+  ~BorealisInstallerTest() override = default;
+
+ protected:
+  void SetUp() override {
+    chromeos::DBusThreadManager::Initialize();
+    CreateProfile();
+
+    installer_ = BorealisInstallerFactory::GetForProfile(profile_.get());
+    observer_ = std::make_unique<StrictMock<MockObserver>>();
+    installer_->AddObserver(observer_.get());
+
+    chromeos::DlcserviceClient::InitializeFake();
+    fake_dlcservice_client_ = static_cast<chromeos::FakeDlcserviceClient*>(
+        chromeos::DlcserviceClient::Get());
+    UpdateCurrentDlcs();
+    ASSERT_EQ(current_dlcs_.dlc_infos_size(), 0);
+  }
+
+  void TearDown() override {
+    observer_.reset();
+    profile_.reset();
+
+    chromeos::DBusThreadManager::Shutdown();
+    chromeos::DlcserviceClient::Shutdown();
+  }
+
+  // Set expectations for observer events up to and including |end_state|.
+  void ExpectObserverEventsUntil(InstallingState end_state) {
+    InstallingState states[] = {
+        InstallingState::kInstallingDlc,
+    };
+
+    for (InstallingState state : states) {
+      EXPECT_CALL(*observer_, OnStateUpdated(state));
+      if (state == end_state)
+        return;
+    }
+
+    NOTREACHED();
+  }
+
+  void StartAndRunToCompletion() {
+    installer_->Start();
+    task_environment_.RunUntilIdle();
+  }
+
+  void UpdateCurrentDlcs() {
+    base::RunLoop run_loop;
+    fake_dlcservice_client_->GetExistingDlcs(base::BindOnce(
+        [](dlcservice::DlcsWithContent* out, base::OnceClosure quit,
+           const std::string& err,
+           const dlcservice::DlcsWithContent& dlcs_with_content) {
+          out->CopyFrom(dlcs_with_content);
+          std::move(quit).Run();
+        },
+        base::Unretained(&current_dlcs_), run_loop.QuitClosure()));
+    run_loop.Run();
+  }
+
+  std::unique_ptr<TestingProfile> profile_;
+  BorealisInstaller* installer_;
+  std::unique_ptr<MockObserver> observer_;
+  content::BrowserTaskEnvironment task_environment_;
+  dlcservice::DlcsWithContent current_dlcs_;
+  base::test::ScopedFeatureList feature_list_;
+
+  // Owned by chromeos::DBusThreadManager
+  chromeos::FakeDlcserviceClient* fake_dlcservice_client_;
+
+ private:
+  void CreateProfile() {
+    TestingProfile::Builder profile_builder;
+    profile_builder.SetProfileName("defaultprofile");
+    profile_ = profile_builder.Build();
+  }
+
+  // Disallow copy and assign.
+  BorealisInstallerTest(const BorealisInstallerTest&) = delete;
+  BorealisInstallerTest& operator=(const BorealisInstallerTest&) = delete;
+};
+
+class BorealisInstallerTestDlc
+    : public BorealisInstallerTest,
+      public testing::WithParamInterface<
+          std::pair<std::string, InstallationResult>> {};
+
+TEST_F(BorealisInstallerTest, BorealisNotAllowed) {
+  feature_list_.InitAndDisableFeature(features::kBorealis);
+
+  EXPECT_CALL(*observer_, OnInstallationEnded(InstallationResult::kNotAllowed));
+
+  StartAndRunToCompletion();
+  UpdateCurrentDlcs();
+  ASSERT_EQ(current_dlcs_.dlc_infos_size(), 0);
+}
+
+TEST_F(BorealisInstallerTest, SucessfulInstallation) {
+  feature_list_.InitAndEnableFeature(features::kBorealis);
+  fake_dlcservice_client_->set_install_error(dlcservice::kErrorNone);
+
+  ExpectObserverEventsUntil(InstallingState::kInstallingDlc);
+  EXPECT_CALL(*observer_, OnInstallationEnded(InstallationResult::kCompleted));
+
+  StartAndRunToCompletion();
+
+  UpdateCurrentDlcs();
+  ASSERT_EQ(current_dlcs_.dlc_infos_size(), 1);
+  EXPECT_EQ(current_dlcs_.dlc_infos(0).id(), borealis::kBorealisDlcName);
+}
+
+TEST_F(BorealisInstallerTest, CancelledInstallation) {
+  feature_list_.InitAndEnableFeature(features::kBorealis);
+  fake_dlcservice_client_->set_install_error(dlcservice::kErrorNone);
+
+  ExpectObserverEventsUntil(InstallingState::kInstallingDlc);
+  EXPECT_CALL(*observer_, OnCancelInitiated());
+  EXPECT_CALL(*observer_, OnInstallationEnded(InstallationResult::kCancelled));
+
+  installer_->Start();
+  installer_->Cancel();
+  task_environment_.RunUntilIdle();
+
+  UpdateCurrentDlcs();
+  ASSERT_EQ(current_dlcs_.dlc_infos_size(), 1);
+  EXPECT_EQ(current_dlcs_.dlc_infos(0).id(), borealis::kBorealisDlcName);
+}
+
+TEST_F(BorealisInstallerTest, BorealisInProgess) {
+  feature_list_.InitAndEnableFeature(features::kBorealis);
+  fake_dlcservice_client_->set_install_error(dlcservice::kErrorNone);
+
+  ExpectObserverEventsUntil(InstallingState::kInstallingDlc);
+  EXPECT_CALL(*observer_,
+              OnInstallationEnded(InstallationResult::kOperationInProgress));
+  EXPECT_CALL(*observer_, OnInstallationEnded(InstallationResult::kCompleted));
+
+  installer_->Start();
+  installer_->Start();
+  task_environment_.RunUntilIdle();
+
+  UpdateCurrentDlcs();
+  ASSERT_EQ(current_dlcs_.dlc_infos_size(), 1);
+  EXPECT_EQ(current_dlcs_.dlc_infos(0).id(), borealis::kBorealisDlcName);
+}
+
+// Note that we don't check if the DLC has/hasn't been installed, since the
+// mocked DLC service will always suceeed, so we only care about how the error
+// code returned by the service is handled by the installer.
+TEST_P(BorealisInstallerTestDlc, DlcError) {
+  feature_list_.InitAndEnableFeature(features::kBorealis);
+  fake_dlcservice_client_->set_install_error(GetParam().first);
+
+  ExpectObserverEventsUntil(InstallingState::kInstallingDlc);
+  EXPECT_CALL(*observer_, OnInstallationEnded(GetParam().second));
+
+  StartAndRunToCompletion();
+}
+
+INSTANTIATE_TEST_SUITE_P(
+    BorealisInstallerTestDlcErrors,
+    BorealisInstallerTestDlc,
+    testing::Values(std::pair<std::string, InstallationResult>(
+                        dlcservice::kErrorInternal,
+                        InstallationResult::kDlcInternal),
+                    std::pair<std::string, InstallationResult>(
+                        dlcservice::kErrorInvalidDlc,
+                        InstallationResult::kDlcUnsupported),
+                    std::pair<std::string, InstallationResult>(
+                        dlcservice::kErrorBusy,
+                        InstallationResult::kDlcBusy),
+                    std::pair<std::string, InstallationResult>(
+                        dlcservice::kErrorNeedReboot,
+                        InstallationResult::kDlcNeedReboot),
+                    std::pair<std::string, InstallationResult>(
+                        dlcservice::kErrorAllocation,
+                        InstallationResult::kDlcNeedSpace),
+                    std::pair<std::string, InstallationResult>(
+                        "unkown",
+                        InstallationResult::kDlcUnknown)));
+}  // namespace borealis