Skip to content

GitLab

T
tangled
Commit 2b5d4968 authored by Salvador Guerrero's avatar Salvador Guerrero Committed by Commit Bot
Browse files
Options

Disabled flaky TabGridDialogTests 

The following tests have been disabled

TabGridDialogTest#testSwipeToDismiss_Dialog
TabGridDialogTest#testUndoClosureInDialog_TabStrip
TabGridDialogTest#testRenderDialog_5Tabs_InitialScroll_NightModeDisabled
TabGridDialogTest#testBackPressCloseDialog
TabGridDialogTest#testTabGridDialogAnimation
TabGridDialogTest#testDialogToolbarMenuShareGroup
TabGridDialogTest#testRenderDialog_5Tabs_InitialScroll_NightModeEnabled
TabGridDialogTest#testRenderDialog_3Tabs_Portrait_NightModeDisabled
TabGridDialogTest#testClickScrimCloseDialog
TabGridDialogTest#testRenderDialog_3Tabs_Landscape_NightModeEnabled
TabGridDialogTest#testSelectionEditorUngroup
TabGridDialogTest#testDisableTabGroupsContinuation
TabGridDialogTest#testUndoClosureInDialog_GTS
TabGridDialogTest#testRenderDialog_3Tabs_Landscape_NightModeDisabled
TabGridDialogTest#testRenderDialog_3Tabs_Portrait_NightModeEnabled
TabGridDialogTest#testDialogInitialShowFromStrip
TabGridDialogTest#testTabGroupNaming

TBR=yusufo@chromium.org

Bug: 1108547
Change-Id: I8edcbc15398dbd71573f9e1310b089038c42f979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314664Reviewed-by: default avatarSalvador Guerrero <salg@google.com>
Commit-Queue: Salvador Guerrero <salg@google.com>
Cr-Commit-Position: refs/heads/master@{#791077}
parent 6881f03d
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 0 deletions
chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogTest.java
View file @ 2b5d4968
......@@ -75,6 +75,7 @@ import org.junit.runner.RunWith;
import org.chromium.base.test.params.ParameterAnnotations;
import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.browser.ChromeActivity;
......@@ -157,6 +158,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testBackPressCloseDialog() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -191,6 +193,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testClickScrimCloseDialog() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -233,6 +236,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testDisableTabGroupsContinuation() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -272,6 +276,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testTabGridDialogAnimation() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -322,6 +327,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testUndoClosureInDialog_GTS() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -351,6 +357,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testUndoClosureInDialog_TabStrip() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -386,6 +393,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
@DisabledTest(message = "https://crbug.com/1108547")
public void testDialogToolbarMenuShareGroup() {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -447,6 +455,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
@DisabledTest(message = "https://crbug.com/1108547")
public void testSelectionEditorUngroup() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
assertTrue(cta.getTabModelSelector().getTabModelFilterProvider().getCurrentTabModelFilter()
......@@ -583,6 +592,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
@DisabledTest(message = "https://crbug.com/1108547")
public void testTabGroupNaming() throws ExecutionException {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
createTabs(cta, false, 2);
......@@ -618,6 +628,7 @@ public class TabGridDialogTest {
@Test
@MediumTest
@DisabledTest(message = "https://crbug.com/1108547")
public void testDialogInitialShowFromStrip() throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 2, 0, "about:blank");
......@@ -642,6 +653,7 @@ public class TabGridDialogTest {
@MediumTest
@Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "https://crbug.com/1108547")
public void testRenderDialog_3Tabs_Portrait(boolean nightModeEnabled) throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 3, 0, "about:blank");
......@@ -662,6 +674,7 @@ public class TabGridDialogTest {
@MediumTest
@Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "https://crbug.com/1108547")
public void testRenderDialog_3Tabs_Landscape(boolean nightModeEnabled) throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 3, 0, "about:blank");
......@@ -683,6 +696,7 @@ public class TabGridDialogTest {
@MediumTest
@Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "https://crbug.com/1108547")
public void testRenderDialog_5Tabs_InitialScroll(boolean nightModeEnabled) throws Exception {
final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
prepareTabsWithThumbnail(mActivityTestRule, 5, 0, "about:blank");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment