Commit 2b5fe283 authored by Oksana Zhuravlova's avatar Oksana Zhuravlova Committed by Commit Bot

[blink] Allow blink files to include .mojom-blink-test-utils.h

This change adds .mojom-blink-test-utils.h to the list of allowed header
suffixes in the presubmit checks.

Bug: 922875
Change-Id: I2cb51817c43a56480ad780f40372dca67ae14e71
Reviewed-on: https://chromium-review.googlesource.com/c/1481088Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634546}
parent 3fbe2645
...@@ -58,8 +58,8 @@ def _CheckForWrongMojomIncludes(input_api, output_api): ...@@ -58,8 +58,8 @@ def _CheckForWrongMojomIncludes(input_api, output_api):
if f.LocalPath().startswith(public_folder) and \ if f.LocalPath().startswith(public_folder) and \
not f.LocalPath() in allow_blink_files: not f.LocalPath() in allow_blink_files:
error_list = public_blink_mojom_errors error_list = public_blink_mojom_errors
elif match.group(1) not in ('-blink', '-blink-forward'): elif match.group(1) not in ('-blink', '-blink-forward', '-blink-test-utils'):
# Neither -shared.h, -blink.h nor -blink-forward.h. # Neither -shared.h, -blink.h, -blink-forward.h nor -blink-test-utils.h.
error_list = non_blink_mojom_errors error_list = non_blink_mojom_errors
if error_list is not None: if error_list is not None:
......
...@@ -129,6 +129,7 @@ class PresubmitTest(unittest.TestCase): ...@@ -129,6 +129,7 @@ class PresubmitTest(unittest.TestCase):
potentially_bad_content = """ potentially_bad_content = """
#include "public/platform/modules/cache_storage.mojom-blink.h" #include "public/platform/modules/cache_storage.mojom-blink.h"
#include "public/platform/modules/cache_storage.mojom-blink-forward.h" #include "public/platform/modules/cache_storage.mojom-blink-forward.h"
#include "public/platform/modules/cache_storage.mojom-blink-test-utils.h"
""" """
mock_input_api.files = [ mock_input_api.files = [
MockAffectedFile('third_party/blink/renderer/core/a_header.h', MockAffectedFile('third_party/blink/renderer/core/a_header.h',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment