Commit 2b64a6ce authored by Armando Miraglia's avatar Armando Miraglia Committed by Commit Bot

[Sheriff] Disabling consistently failing SafetyTipPageInfoBubbleViewBrowserTest.* tests.

During sheriffing I have attempted to determine the reason for failing for two
tests in SafetyTipPageInfoBubbleViewBrowserTest but did not manage. I am
hence disabling for later further investigation.

TBR=estark@chromium.org

Bug: 1020109
Change-Id: I78419a0101cfbcad04f9b4c09553de6ea442c18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891175Reviewed-by: default avatarArmando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711216}
parent ef5c70b3
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "base/test/metrics/histogram_tester.h" #include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h" #include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/browser/engagement/site_engagement_score.h" #include "chrome/browser/engagement/site_engagement_score.h"
#include "chrome/browser/engagement/site_engagement_service.h" #include "chrome/browser/engagement/site_engagement_service.h"
#include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/history/history_service_factory.h"
...@@ -571,6 +572,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -571,6 +572,12 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
EXPECT_FALSE(IsUIShowing()); EXPECT_FALSE(IsUIShowing());
} }
// Disabled due to consistent failure: http://crbug.com/1020109
#if defined(OS_LINUX)
#define MAYBE_TriggersOnEditDistance DISABLED_TriggersOnEditDistance
#else
#define MAYBE_TriggersOnEditDistance TriggersOnEditDistance
#endif
// Tests that Safety Tips trigger (or not) on lookalike domains with edit // Tests that Safety Tips trigger (or not) on lookalike domains with edit
// distance when enabled, and not otherwise. // distance when enabled, and not otherwise.
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
...@@ -625,9 +632,15 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -625,9 +632,15 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
1); 1);
} }
// Disabled due to consistent failure: http://crbug.com/1020109
#if defined(OS_LINUX)
#define MAYBE_InteractionsHistogram DISABLED_InteractionsHistogram
#else
#define MAYBE_InteractionsHistogram InteractionsHistogram
#endif
// Tests that Safety Tip interactions are recorded in a histogram. // Tests that Safety Tip interactions are recorded in a histogram.
IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
InteractionsHistogram) { MAYBE_InteractionsHistogram) {
const std::string kHistogramPrefix = "Security.SafetyTips.Interaction."; const std::string kHistogramPrefix = "Security.SafetyTips.Interaction.";
// These histograms are only recorded when the UI feature is enabled, so bail // These histograms are only recorded when the UI feature is enabled, so bail
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment