Commit 2b73a4f3 authored by John Z Wu's avatar John Z Wu Committed by Commit Bot

Clean up some stale TODOs and comments

Bug: 723854
Change-Id: I6cb7a4c60dd458c76d59019175c04984e0b75abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904757Reviewed-by: default avatarHiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713884}
parent 77d64d6e
...@@ -72,7 +72,6 @@ void ApplicationContext::PreCreateThreads() { ...@@ -72,7 +72,6 @@ void ApplicationContext::PreCreateThreads() {
void ApplicationContext::SaveState() { void ApplicationContext::SaveState() {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
// TODO(crbug.com/723854): Commit prefs when entering background.
if (local_state_) { if (local_state_) {
local_state_->CommitPendingWrite(); local_state_->CommitPendingWrite();
} }
......
...@@ -113,7 +113,6 @@ NSArray<NSAttributedString*>* CWVLegalMessagesFromLegalMessageLines( ...@@ -113,7 +113,6 @@ NSArray<NSAttributedString*>* CWVLegalMessagesFromLegalMessageLines(
_saveCompletionHandler = completionHandler; _saveCompletionHandler = completionHandler;
DCHECK(_uploadSaveCardCallback); DCHECK(_uploadSaveCardCallback);
// TODO(crbug.com/993130): Provide additional card details if required.
std::move(_uploadSaveCardCallback) std::move(_uploadSaveCardCallback)
.Run(autofill::AutofillClient::ACCEPTED, .Run(autofill::AutofillClient::ACCEPTED,
/*user_provided_card_details=*/{}); /*user_provided_card_details=*/{});
......
...@@ -135,7 +135,7 @@ base::RepeatingClosure WebViewSyncClient::GetPasswordStateChangedCallback() { ...@@ -135,7 +135,7 @@ base::RepeatingClosure WebViewSyncClient::GetPasswordStateChangedCallback() {
syncer::DataTypeController::TypeVector syncer::DataTypeController::TypeVector
WebViewSyncClient::CreateDataTypeControllers( WebViewSyncClient::CreateDataTypeControllers(
syncer::SyncService* sync_service) { syncer::SyncService* sync_service) {
// iOS WebView uses butter sync and so has no need to record user consents. // //ios/web_view clients are supposed to record their own consents.
syncer::DataTypeController::TypeVector type_vector = syncer::DataTypeController::TypeVector type_vector =
component_factory_->CreateCommonDataTypeControllers(GetDisabledTypes(), component_factory_->CreateCommonDataTypeControllers(GetDisabledTypes(),
sync_service); sync_service);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment