Commit 2bb28a2d authored by Roman Sorokin's avatar Roman Sorokin Committed by Commit Bot

Chromad: Remove DCHECK on password plain text

Don't DCHECK on password being plain text in existing user controller.
Make it if statement.

BUG=chromium:839314
TEST=manual

Change-Id: I7a649ddb922edd2105563cb2b4959b764d0383a4
Reviewed-on: https://chromium-review.googlesource.com/1041958
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555753}
parent 2756f3cf
......@@ -585,8 +585,12 @@ void ExistingUserController::PerformLogin(
}
if (user_context.GetAccountId().GetAccountType() ==
AccountType::ACTIVE_DIRECTORY &&
user_context.GetAuthFlow() == UserContext::AUTH_FLOW_OFFLINE) {
DCHECK(user_context.GetKey()->GetKeyType() == Key::KEY_TYPE_PASSWORD_PLAIN);
user_context.GetAuthFlow() == UserContext::AUTH_FLOW_OFFLINE &&
user_context.GetKey()->GetKeyType() == Key::KEY_TYPE_PASSWORD_PLAIN) {
// Skip TryAuthenticateUser() below when password is hashed. Views-based
// login sends hashed password back and TryAuthenticateUser() is called
// there before it sends back the hashed password
// Try to get kerberos TGT while we have user's password typed on the pod
// screen. Failure to get TGT here is OK - that could mean e.g. Active
// Directory server is not reachable. We don't want to have user wait for
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment