Fix few trivial Coverity issues, mainly PASS_BY_VALUE.

Review URL: http://codereview.chromium.org/155022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19974 0039d316-1c4b-4281-b951-d872f2087c98

base/directory_watcher_unittest.cc

@@ -27,7 +27,10 @@ const int kWaitForEventTime = 1000;
 class DirectoryWatcherTest : public testing::Test {
  public:
   // Implementation of DirectoryWatcher on Mac requires UI loop.
-  DirectoryWatcherTest() : loop_(MessageLoop::TYPE_UI) {
+  DirectoryWatcherTest()
+      : loop_(MessageLoop::TYPE_UI),
+        notified_delegates_(0),
+        expected_notified_delegates_(0) {
   }
 
   void OnTestDelegateFirstNotification(const FilePath& path) {

base/file_path.cc

@@ -83,7 +83,7 @@ bool IsPathAbsolute(const FilePath::StringType& path) {
 #endif  // FILE_PATH_USES_DRIVE_LETTERS
 }
 
-bool AreAllSeparators(FilePath::StringType input) {
+bool AreAllSeparators(const FilePath::StringType& input) {
   for (FilePath::StringType::const_iterator it = input.begin();
       it != input.end(); ++it) {
     if (!FilePath::IsSeparator(*it))

base/simple_thread.h

@@ -152,7 +152,7 @@ class DelegateSimpleThreadPool : public DelegateSimpleThread::Delegate {
  public:
   typedef DelegateSimpleThread::Delegate Delegate;
 
-  DelegateSimpleThreadPool(const std::string name_prefix, int num_threads)
+  DelegateSimpleThreadPool(const std::string& name_prefix, int num_threads)
       : name_prefix_(name_prefix), num_threads_(num_threads),
         dry_(true, false) { }
   ~DelegateSimpleThreadPool();

base/tracked_objects.cc

@@ -765,7 +765,7 @@ bool Comparator::Acceptable(const Snapshot& sample) const {
   return true;
 }
 
-void Comparator::SetTiebreaker(Selector selector, const std::string required) {
+void Comparator::SetTiebreaker(Selector selector, const std::string& required) {
   if (selector == selector_ || NIL == selector)
     return;
   combined_selectors_ |= selector;
@@ -804,7 +804,7 @@ void Comparator::SetSubgroupTiebreaker(Selector selector) {
   }
 }
 
-void Comparator::ParseKeyphrase(const std::string key_phrase) {
+void Comparator::ParseKeyphrase(const std::string& key_phrase) {
   static std::map<const std::string, Selector> key_map;
   static bool initialized = false;
   if (!initialized) {
@@ -829,7 +829,7 @@ void Comparator::ParseKeyphrase(const std::string key_phrase) {
   SetTiebreaker(key_map[keyword], required);
 }
 
-bool Comparator::ParseQuery(const std::string query) {
+bool Comparator::ParseQuery(const std::string& query) {
   for (size_t i = 0; i < query.size();) {
     size_t slash_offset = query.find('/', i);
     ParseKeyphrase(query.substr(i, slash_offset - i));

base/tracked_objects.h

@@ -255,7 +255,7 @@ class Comparator {
   // A comparator can be refined by specifying what to do if the selected basis
   // for comparison is insufficient to establish an ordering.  This call adds
   // the indicated attribute as the new "least significant" basis of comparison.
-  void SetTiebreaker(Selector selector, const std::string required);
+  void SetTiebreaker(Selector selector, const std::string& required);
 
   // Indicate if this instance is set up to sort by the given Selector, thereby
   // putting that information in the SortGrouping, so it is not needed in each
@@ -268,10 +268,10 @@ class Comparator {
   void SetSubgroupTiebreaker(Selector selector);
 
   // Translate a keyword and restriction in URL path to a selector for sorting.
-  void ParseKeyphrase(const std::string key_phrase);
+  void ParseKeyphrase(const std::string& key_phrase);
 
   // Parse a query in an about:objects URL to decide on sort ordering.
-  bool ParseQuery(const std::string query);
+  bool ParseQuery(const std::string& query);
 
   // Output a header line that can be used to indicated what items will be
   // collected in the group.  It lists all (potentially) tested attributes and

net/base/x509_certificate.h

@@ -75,7 +75,7 @@ class X509Certificate : public base::RefCountedThreadSafe<X509Certificate> {
   // Principal represent an X.509 principal.
   struct Principal {
     Principal() { }
-    explicit Principal(std::string name) : common_name(name) { }
+    explicit Principal(const std::string& name) : common_name(name) { }
 
     // The different attributes for a principal.  They may be "".
     // Note that some of them can have several values.