Commit 2bd65742 authored by Alice Wang's avatar Alice Wang Committed by Commit Bot

[Android][Signin] Disable bookmark promo tests

This CL disables the flaky bookmark promo dismiss tests.

TBR=bsazonov@chromium.org

Bug: 1020068
Bug: 1020069
Change-Id: I003baa162588b14eae1f480fa69fb5e72edf9f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899375
Auto-Submit: Alice Wang <aliceywang@chromium.org>
Reviewed-by: default avatarAlex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712954}
parent 5f6873ad
...@@ -25,6 +25,7 @@ import org.junit.Test; ...@@ -25,6 +25,7 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
...@@ -61,6 +62,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest { ...@@ -61,6 +62,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
@Test @Test
@MediumTest @MediumTest
@FlakyTest(message = "https://crbug.com/1020068")
public void testPromoNotShownAfterBeingDismissed() { public void testPromoNotShownAfterBeingDismissed() {
BookmarkTestUtil.showBookmarkManager(mActivityTestRule.getActivity()); BookmarkTestUtil.showBookmarkManager(mActivityTestRule.getActivity());
onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed())); onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
...@@ -95,6 +97,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest { ...@@ -95,6 +97,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
@Test @Test
@MediumTest @MediumTest
@FlakyTest(message = "https://crbug.com/1020069")
public void testPromoImpressionCountIncrementAfterDisplayingSigninPromo() { public void testPromoImpressionCountIncrementAfterDisplayingSigninPromo() {
assertEquals(0, SigninPromoController.getSigninPromoImpressionsCountBookmarksForTests()); assertEquals(0, SigninPromoController.getSigninPromoImpressionsCountBookmarksForTests());
BookmarkTestUtil.showBookmarkManager(mActivityTestRule.getActivity()); BookmarkTestUtil.showBookmarkManager(mActivityTestRule.getActivity());
......
...@@ -30,7 +30,6 @@ import org.junit.Test; ...@@ -30,7 +30,6 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
...@@ -81,7 +80,6 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -81,7 +80,6 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@FlakyTest(message = "https://crbug.com/1020069")
public void testSigninButtonDefaultAccount() { public void testSigninButtonDefaultAccount() {
doNothing() doNothing()
.when(SigninActivityLauncher.get()) .when(SigninActivityLauncher.get())
...@@ -96,7 +94,6 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -96,7 +94,6 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@FlakyTest(message = "https://crbug.com/1020069")
public void testSigninButtonNotDefaultAccount() { public void testSigninButtonNotDefaultAccount() {
doNothing() doNothing()
.when(SigninActivityLauncher.get()) .when(SigninActivityLauncher.get())
...@@ -111,7 +108,6 @@ public class BookmarkPersonalizedSigninPromoTest { ...@@ -111,7 +108,6 @@ public class BookmarkPersonalizedSigninPromoTest {
@Test @Test
@MediumTest @MediumTest
@FlakyTest(message = "https://crbug.com/1020069")
public void testSigninButtonNewAccount() { public void testSigninButtonNewAccount() {
doNothing() doNothing()
.when(SigninActivityLauncher.get()) .when(SigninActivityLauncher.get())
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment