Commit 2bdaf0af authored by Navid Zolghadr's avatar Navid Zolghadr Committed by Commit Bot

Remove old input metrics that were replaced

Remove old touch scrolling metrics that were
replaced back in M56.

Bug: 649754
Change-Id: If47392ac6902bd9cf4e8a001752943e0f615ba70
Reviewed-on: https://chromium-review.googlesource.com/728714Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510218}
parent e43ca886
......@@ -477,10 +477,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToFirstScrollHistograms) {
// UMA histograms.
EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.TouchUI", 1));
EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.TouchAcked", 1));
EXPECT_TRUE(
HistogramSizeEq("Event.Latency.TouchToFirstScrollUpdateSwapBegin", 1));
EXPECT_TRUE(
HistogramSizeEq("Event.Latency.TouchToScrollUpdateSwapBegin", 1));
EXPECT_TRUE(HistogramSizeEq(
"Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2", 1));
......@@ -730,9 +726,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest,
EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.TouchUI", 1));
EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.WheelAcked", 1));
EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.TouchAcked", 1));
EXPECT_TRUE(
HistogramSizeEq("Event.Latency.TouchToFirstScrollUpdateSwapBegin", 1));
EXPECT_TRUE(HistogramSizeEq("Event.Latency.TouchToScrollUpdateSwapBegin", 1));
EXPECT_TRUE(
HistogramSizeEq("Event.Latency.ScrollUpdate.TouchToHandled_Main", 0));
EXPECT_TRUE(
......
......@@ -20193,6 +20193,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Event.Latency.TouchToFirstScrollUpdateSwapBegin"
units="microseconds">
<obsolete>
Replaced by Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin2.
</obsolete>
<owner>tdresser@chromium.org</owner>
<summary>
Time between initial creation of a touch event and the start of the frame
......@@ -20222,6 +20225,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Event.Latency.TouchToScrollUpdateSwapBegin"
units="microseconds">
<obsolete>
Replaced by Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin2.
</obsolete>
<owner>tdresser@chromium.org</owner>
<summary>
Time between initial creation of a touch event and start of the frame swap
......@@ -25,43 +25,6 @@ std::string LatencySourceEventTypeToInputModalityString(
}
}
void ComputeScrollLatencyHistograms(
const LatencyInfo::LatencyComponent& gpu_swap_begin_component,
const LatencyInfo::LatencyComponent& gpu_swap_end_component,
const LatencyInfo& latency) {
DCHECK(!latency.coalesced());
if (latency.coalesced())
return;
DCHECK(!gpu_swap_begin_component.event_time.is_null());
DCHECK(!gpu_swap_end_component.event_time.is_null());
LatencyInfo::LatencyComponent original_component;
if (latency.FindLatency(
ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
&original_component)) {
// This UMA metric tracks the time between the final frame swap for the
// first scroll event in a sequence and the original timestamp of that
// scroll event's underlying touch event.
for (size_t i = 0; i < original_component.event_count; i++) {
UMA_HISTOGRAM_INPUT_LATENCY_HIGH_RESOLUTION_MICROSECONDS(
"Event.Latency.TouchToFirstScrollUpdateSwapBegin", original_component,
gpu_swap_begin_component);
}
} else if (!latency.FindLatency(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
&original_component)) {
return;
}
// This UMA metric tracks the time from when the original touch event is
// created to when the scroll gesture results in final frame swap.
for (size_t i = 0; i < original_component.event_count; i++) {
UMA_HISTOGRAM_INPUT_LATENCY_HIGH_RESOLUTION_MICROSECONDS(
"Event.Latency.TouchToScrollUpdateSwapBegin", original_component,
gpu_swap_begin_component);
}
}
} // namespace
void LatencyTracker::OnGpuSwapBuffersCompleted(const LatencyInfo& latency) {
......@@ -100,16 +63,6 @@ void LatencyTracker::OnGpuSwapBuffersCompleted(const LatencyInfo& latency) {
gpu_swap_end_component, latency);
}
// Compute the old scroll update latency metrics. They are exclusively
// calculated for touch scrolls, and will be deprecated on M56.
// (https://crbug.com/649754)
LatencyInfo::LatencyComponent mouse_wheel_scroll_update_component;
if (!latency.FindLatency(
ui::INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL, 0,
&mouse_wheel_scroll_update_component)) {
ComputeScrollLatencyHistograms(gpu_swap_begin_component,
gpu_swap_end_component, latency);
}
}
void LatencyTracker::ReportRapporScrollLatency(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment