Commit 2bf21f3d authored by Dave Tapuska's avatar Dave Tapuska Committed by Commit Bot

Remove some dead code in WebViewImpl/WebFrameWidgetImpl.

This code is no longer called. Remove it.

BUG=1097816

Change-Id: I7f00f96c5fa7de9e7219db19db2bd0fade3e2c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536781
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatardanakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828526}
parent 7f683b76
......@@ -1822,7 +1822,6 @@ void WebViewImpl::SetFocus(bool enable) {
}
}
}
ime_accept_events_ = true;
} else {
CancelPagePopup();
......@@ -1847,7 +1846,6 @@ void WebViewImpl::SetFocus(bool enable) {
focused_frame->GetInputMethodController().FinishComposingText(
InputMethodController::kKeepSelection);
}
ime_accept_events_ = false;
}
}
}
......@@ -3576,10 +3574,6 @@ LocalFrame* WebViewImpl::FocusedLocalFrameInWidget() const {
return focused_frame;
}
LocalFrame* WebViewImpl::FocusedLocalFrameAvailableForIme() const {
return ime_accept_events_ ? FocusedLocalFrameInWidget() : nullptr;
}
void WebViewImpl::SetPageFrozen(bool frozen) {
Scheduler()->SetPageFrozen(frozen);
web_view_client_->OnPageFrozenChanged(frozen);
......
......@@ -600,7 +600,6 @@ class CORE_EXPORT WebViewImpl final : public WebView,
void DidChangeRootLayer(bool root_layer_exists);
LocalFrame* FocusedLocalFrameInWidget() const;
LocalFrame* FocusedLocalFrameAvailableForIme() const;
// Clear focus and text input state of the page. If there was a focused
// element, this will trigger updates to observers and send focus, selection,
......@@ -715,11 +714,6 @@ class CORE_EXPORT WebViewImpl final : public WebView,
float compositor_device_scale_factor_override_ = 0.f;
TransformationMatrix device_emulation_transform_;
// TODO(ekaramad): Can we remove this and make sure IME events are not called
// when there is no page focus?
// Represents whether or not this object should process incoming IME events.
bool ime_accept_events_ = true;
// The popup associated with an input/select element. The popup is owned via
// closership (self-owned-but-deleted-via-close) by RenderWidget. We also hold
// a reference here because we can extend the lifetime of the popup while
......
......@@ -367,7 +367,6 @@ void WebFrameWidgetImpl::FocusChanged(bool enable) {
}
}
}
ime_accept_events_ = true;
} else {
LocalFrame* focused_frame = FocusedLocalFrameInWidget();
if (focused_frame) {
......@@ -382,7 +381,6 @@ void WebFrameWidgetImpl::FocusChanged(bool enable) {
focused_frame->GetInputMethodController().FinishComposingText(
InputMethodController::kKeepSelection);
}
ime_accept_events_ = false;
}
}
}
......@@ -498,12 +496,6 @@ void WebFrameWidgetImpl::SetAutoResizeMode(bool auto_resize,
// Auto resize mode only exists on the top level widget.
}
LocalFrame* WebFrameWidgetImpl::FocusedLocalFrameAvailableForIme() const {
if (!ime_accept_events_)
return nullptr;
return FocusedLocalFrameInWidget();
}
void WebFrameWidgetImpl::DidCreateLocalRootView() {
// If this WebWidget still hasn't received its size from the embedder, block
// the parser. This is necessary, because the parser can cause layout to
......
......@@ -122,16 +122,12 @@ class WebFrameWidgetImpl final : public WebFrameWidgetBase {
private:
friend class WebFrameWidget; // For WebFrameWidget::create.
void UpdateLayerTreeViewport();
// PageWidgetEventHandler functions
void HandleMouseLeave(LocalFrame&, const WebMouseEvent&) override;
WebInputEventResult HandleGestureEvent(const WebGestureEvent&) override;
LocalFrameView* GetLocalFrameViewForAnimationScrolling() override;
LocalFrame* FocusedLocalFrameAvailableForIme() const;
// Finds the parameters required for scrolling the focused editable |element|
// into view. |rect_to_scroll| is used for recursive scrolling of the element
// into view and contains all or part of element's bounding box and always
......@@ -143,16 +139,8 @@ class WebFrameWidgetImpl final : public WebFrameWidgetBase {
base::Optional<gfx::Size> size_;
// Metrics gathering timing information
base::Optional<base::TimeTicks> update_layers_start_time_;
bool did_suspend_parsing_ = false;
// TODO(ekaramad): Can we remove this and make sure IME events are not called
// when there is no page focus?
// Represents whether or not this object should process incoming IME events.
bool ime_accept_events_ = true;
SelfKeepAlive<WebFrameWidgetImpl> self_keep_alive_;
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment