KSV: Only clear search on esc/back key press.

Avoid clearing the text/search on escape key release only.
(eg. when a context menu closes, consuming the press event)

Bug: NONE
Test: KSV search not cleared pressing escape to close a context menu.
Change-Id: Iaee63b9e31bf371ec3d95fd9ef4b688c0254b697
Reviewed-on: https://chromium-review.googlesource.com/c/1295171Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601786}

ash/components/shortcut_viewer/views/ksv_search_box_view.cc

@@ -56,15 +56,16 @@ void KSVSearchBoxView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
 
 void KSVSearchBoxView::OnKeyEvent(ui::KeyEvent* event) {
   const ui::KeyboardCode key = event->key_code();
-  const bool is_escape_key = (key == ui::VKEY_ESCAPE);
-  if (!is_escape_key && key != ui::VKEY_BROWSER_BACK)
+  if ((key != ui::VKEY_ESCAPE && key != ui::VKEY_BROWSER_BACK) ||
+      event->type() != ui::ET_KEY_PRESSED) {
     return;
+  }
 
   event->SetHandled();
   // |VKEY_BROWSER_BACK| will only clear all the text.
   ClearSearch();
   // |VKEY_ESCAPE| will clear text and exit search mode directly.
-  if (is_escape_key)
+  if (key == ui::VKEY_ESCAPE)
     SetSearchBoxActive(false, event->type());
 }