Fix handling of speculative render frames that die without a navigation request.
NavigationControllerBrowserTest.SameDocumentNavigationToHttpPortZero exposed this by killing the renderer for having sent a bad message from ValidateDidCommitParams. By that point the |navigation_request_| has been consumed so ResetNavigationRequest does nothing and so CancelPendingIfNecessary does not destroy the speculative render frame. This test only fails when RenderDocument for subframes is enabled however, it seems it could happen without that. The fix is to ensure that CleanUpNavigation gets called even if there is no navigation_request_. Bug: 1100745 Change-Id: Icdcc17822be04237e9f038063d45ec993dc7ed92 Fixed: 1100745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275640 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#791699}
Showing
Please register or sign in to comment