Commit 2c63bfd4 authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot

Remove use of performance_manager::GetSerializationId.

The serialization ID is slated for removal, and local ID assignment
is sufficient for this metrics provider.

Bug: 1071090
Change-Id: I73165ae30636a834fc9d1294d3dbf40ed308d48b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150234Reviewed-by: default avatarChris Hamilton <chrisha@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759405}
parent 9ca049b1
......@@ -10,6 +10,7 @@
#include "base/bind.h"
#include "base/compiler_specific.h"
#include "base/containers/flat_map.h"
#include "base/containers/flat_set.h"
#include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h"
......@@ -967,6 +968,8 @@ void ProcessMemoryMetricsEmitter::GetProcessToPageInfoMap(
std::vector<ProcessInfo> process_infos;
std::vector<const performance_manager::ProcessNode*> process_nodes =
graph->GetAllProcessNodes();
// Assign page nodes unique IDs within this lookup only.
base::flat_map<const performance_manager::PageNode*, uint64_t> page_id_map;
for (auto* process_node : process_nodes) {
if (process_node->GetProcessId() == base::kNullProcessId)
continue;
......@@ -982,10 +985,14 @@ void ProcessMemoryMetricsEmitter::GetProcessToPageInfoMap(
if (page_node->GetUkmSourceID() == ukm::kInvalidSourceId)
continue;
if (page_id_map.find(page_node) == page_id_map.end())
page_id_map.insert(std::make_pair(page_node, page_id_map.size() + 1));
PageInfo page_info;
page_info.ukm_source_id = page_node->GetUkmSourceID();
page_info.tab_id =
performance_manager::Node::GetSerializationId(page_node);
DCHECK(page_id_map.find(page_node) != page_id_map.end());
page_info.tab_id = page_id_map[page_node];
page_info.hosts_main_frame = HostsMainFrame(process_node, page_node);
page_info.is_visible = page_node->IsVisible();
page_info.time_since_last_visibility_change =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment