Commit 2c666ad3 authored by Vikas Soni's avatar Vikas Soni Committed by Commit Bot

Fix lifetime of SurfaceOwner.

CL https://chromium-review.googlesource.com/c/chromium/src/+/1616526
changed the lifetime of SurfaceOwner which was incorrect and causing
crashes. This is because VideoFrame can outlive the GpuChannel and hence
SurfaceOwner shouldn't be destroyed when GpuChannel is gone since
VideoFrame uses SurfaceOwner.

Bug: 983595
Change-Id: I25cf066ae76920748a438cf51bd07399eaff3ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703482Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678028}
parent a77f23a5
......@@ -142,11 +142,6 @@ void StreamTexture::ReleaseChannel() {
sync_point_client_state_->Destroy();
sync_point_client_state_ = nullptr;
channel_ = nullptr;
// If the channel goes away, there is no need to keep the SurfaceTexture
// around. The GL texture will keep working regardless with the currently
// bound frame.
surface_owner_ = nullptr;
}
// gpu::gles2::GLStreamTextureMatrix implementation
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment