Commit 2c7db28c authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Disable JSONSchemaCompiler tests

The tests started to fail on
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests when
https://crbug.com/1113513#c16 was landed.
The revert was supposed to fix other failures.

Tbr: karandeepb@chromium.org
Bug: 1113513
Change-Id: Ia800eba3f90cf3be44bd800c999d7a694f819573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517567Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823954}
parent 6b822133
...@@ -640,7 +640,8 @@ TEST_P(SingleRulesetTest, InvalidJSONRules_StrongTypes) { ...@@ -640,7 +640,8 @@ TEST_P(SingleRulesetTest, InvalidJSONRules_StrongTypes) {
// Ensures that rules which can't be parsed are ignored and cause an install // Ensures that rules which can't be parsed are ignored and cause an install
// warning. // warning.
TEST_P(SingleRulesetTest, InvalidJSONRules_Parsed) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST_P(SingleRulesetTest, DISABLED_InvalidJSONRules_Parsed) {
const char* kRules = R"( const char* kRules = R"(
[ [
{ {
......
...@@ -146,7 +146,8 @@ TEST(JsonSchemaCompilerErrorTest, WrongParameterCreationType) { ...@@ -146,7 +146,8 @@ TEST(JsonSchemaCompilerErrorTest, WrongParameterCreationType) {
} }
} }
TEST(JsonSchemaCompilerErrorTest, WrongTypeValueType) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_WrongTypeValueType) {
{ {
auto value = std::make_unique<base::DictionaryValue>(); auto value = std::make_unique<base::DictionaryValue>();
EXPECT_TRUE(EqualsUtf16("", GetPopulateError<errors::ObjectType>(*value))); EXPECT_TRUE(EqualsUtf16("", GetPopulateError<errors::ObjectType>(*value)));
...@@ -227,8 +228,8 @@ TEST(JsonSchemaCompilerErrorTest, BadEnumValue) { ...@@ -227,8 +228,8 @@ TEST(JsonSchemaCompilerErrorTest, BadEnumValue) {
} }
// Warn but don't fail out errors // Warn but don't fail out errors
// Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, WarnOnOptionalFailure) { TEST(JsonSchemaCompilerErrorTest, DISABLED_WarnOnOptionalFailure) {
{ {
std::unique_ptr<base::DictionaryValue> value = std::unique_ptr<base::DictionaryValue> value =
Dictionary("string", std::make_unique<Value>("bling")); Dictionary("string", std::make_unique<Value>("bling"));
...@@ -248,7 +249,8 @@ TEST(JsonSchemaCompilerErrorTest, WarnOnOptionalFailure) { ...@@ -248,7 +249,8 @@ TEST(JsonSchemaCompilerErrorTest, WarnOnOptionalFailure) {
} }
} }
TEST(JsonSchemaCompilerErrorTest, OptionalBinaryTypeFailure) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalBinaryTypeFailure) {
{ {
std::unique_ptr<base::DictionaryValue> value = std::unique_ptr<base::DictionaryValue> value =
Dictionary("data", std::make_unique<Value>(Value::Type::BINARY)); Dictionary("data", std::make_unique<Value>(Value::Type::BINARY));
...@@ -269,7 +271,8 @@ TEST(JsonSchemaCompilerErrorTest, OptionalBinaryTypeFailure) { ...@@ -269,7 +271,8 @@ TEST(JsonSchemaCompilerErrorTest, OptionalBinaryTypeFailure) {
} }
} }
TEST(JsonSchemaCompilerErrorTest, OptionalArrayTypeFailure) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalArrayTypeFailure) {
{ {
std::unique_ptr<base::DictionaryValue> value = std::unique_ptr<base::DictionaryValue> value =
Dictionary("TheArray", std::make_unique<base::ListValue>()); Dictionary("TheArray", std::make_unique<base::ListValue>());
...@@ -287,7 +290,8 @@ TEST(JsonSchemaCompilerErrorTest, OptionalArrayTypeFailure) { ...@@ -287,7 +290,8 @@ TEST(JsonSchemaCompilerErrorTest, OptionalArrayTypeFailure) {
} }
} }
TEST(JsonSchemaCompilerErrorTest, OptionalUnableToPopulateArray) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_OptionalUnableToPopulateArray) {
{ {
std::unique_ptr<base::ListValue> params_value = std::unique_ptr<base::ListValue> params_value =
List(std::make_unique<Value>(5)); List(std::make_unique<Value>(5));
...@@ -309,7 +313,8 @@ TEST(JsonSchemaCompilerErrorTest, OptionalUnableToPopulateArray) { ...@@ -309,7 +313,8 @@ TEST(JsonSchemaCompilerErrorTest, OptionalUnableToPopulateArray) {
} }
} }
TEST(JsonSchemaCompilerErrorTest, MultiplePopulationErrors) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_MultiplePopulationErrors) {
{ {
std::unique_ptr<base::DictionaryValue> value = std::unique_ptr<base::DictionaryValue> value =
Dictionary("TheArray", std::make_unique<Value>(5)); Dictionary("TheArray", std::make_unique<Value>(5));
...@@ -328,7 +333,8 @@ TEST(JsonSchemaCompilerErrorTest, MultiplePopulationErrors) { ...@@ -328,7 +333,8 @@ TEST(JsonSchemaCompilerErrorTest, MultiplePopulationErrors) {
} }
} }
TEST(JsonSchemaCompilerErrorTest, TooManyKeys) { // Disabled due to consistent failures on some bots https://crbug.com/1113513.
TEST(JsonSchemaCompilerErrorTest, DISABLED_TooManyKeys) {
{ {
std::unique_ptr<base::DictionaryValue> value = std::unique_ptr<base::DictionaryValue> value =
Dictionary("string", std::make_unique<Value>("yes")); Dictionary("string", std::make_unique<Value>("yes"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment