Commit 2c85245e authored by sgk@google.com's avatar sgk@google.com

Add duplicate 'conditions' blocks that define the '<(BRANDING)'

variable for the 'OS=="win"' targets that use it, to work around
an apparent problem in the gyp variable expansion.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17208 0039d316-1c4b-4281-b951-d872f2087c98
parent e0262c9d
......@@ -396,6 +396,24 @@
],
},
],
# TODO(mark): <(BRANDING) should be defined by the
# global condition block at the bottom of the file, but
# this doesn't work due to the following issue:
#
# http://code.google.com/p/gyp/issues/detail?id=22
#
# Remove this block once the above issue is fixed.
'conditions': [
[ 'branding == "Chrome"', {
'variables': {
'BRANDING': '../../chrome/app/theme/google_chrome/BRANDING',
},
}, { # else branding!="Chrome"
'variables': {
'BRANDING': '../../chrome/app/theme/chromium/BRANDING',
},
}],
],
},
{
'target_name': 'mini_installer_test',
......@@ -522,6 +540,24 @@
],
},
],
# TODO(mark): <(BRANDING) should be defined by the
# global condition block at the bottom of the file, but
# this doesn't work due to the following issue:
#
# http://code.google.com/p/gyp/issues/detail?id=22
#
# Remove this block once the above issue is fixed.
'conditions': [
[ 'branding == "Chrome"', {
'variables': {
'BRANDING': '../../chrome/app/theme/google_chrome/BRANDING',
},
}, { # else branding!="Chrome"
'variables': {
'BRANDING': '../../chrome/app/theme/chromium/BRANDING',
},
}],
],
},
],
}],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment