Commit 2c8a348f authored by Ilya Sherman's avatar Ilya Sherman Committed by Commit Bot

Remove the CrosHealthdMetricsProvider

This provider is preventing the AsyncInit task from ever completing,
which is causing a major drop-off in Chrome OS metrics.

Bug: b:165076656
Change-Id: I4d8a700b3b11a6cb9db4fddeebc75e5484a0d137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368142
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Reviewed-by: default avatarWeilun Shi <sweilun@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800444}
parent f1d29484
...@@ -148,7 +148,6 @@ ...@@ -148,7 +148,6 @@
#include "chrome/browser/metrics/ambient_mode_metrics_provider.h" #include "chrome/browser/metrics/ambient_mode_metrics_provider.h"
#include "chrome/browser/metrics/assistant_service_metrics_provider.h" #include "chrome/browser/metrics/assistant_service_metrics_provider.h"
#include "chrome/browser/metrics/chromeos_metrics_provider.h" #include "chrome/browser/metrics/chromeos_metrics_provider.h"
#include "chrome/browser/metrics/cros_healthd_metrics_provider.h"
#include "chrome/browser/signin/signin_status_metrics_provider_chromeos.h" #include "chrome/browser/signin/signin_status_metrics_provider_chromeos.h"
#include "components/metrics/structured/structured_metrics_provider.h" #include "components/metrics/structured/structured_metrics_provider.h"
#endif #endif
...@@ -709,9 +708,6 @@ void ChromeMetricsServiceClient::RegisterMetricsServiceProviders() { ...@@ -709,9 +708,6 @@ void ChromeMetricsServiceClient::RegisterMetricsServiceProviders() {
std::make_unique<ChromeOSMetricsProvider>( std::make_unique<ChromeOSMetricsProvider>(
metrics::MetricsLogUploader::UMA)); metrics::MetricsLogUploader::UMA));
metrics_service_->RegisterMetricsProvider(
std::make_unique<CrosHealthdMetricsProvider>());
metrics_service_->RegisterMetricsProvider( metrics_service_->RegisterMetricsProvider(
std::make_unique<SigninStatusMetricsProviderChromeOS>()); std::make_unique<SigninStatusMetricsProviderChromeOS>());
......
...@@ -177,10 +177,10 @@ TEST_F(ChromeMetricsServiceClientTest, TestRegisterMetricsServiceProviders) { ...@@ -177,10 +177,10 @@ TEST_F(ChromeMetricsServiceClientTest, TestRegisterMetricsServiceProviders) {
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
// AmbientModeMetricsProvider, AssistantServiceMetricsProvider, // AmbientModeMetricsProvider, AssistantServiceMetricsProvider,
// CrosHealthdMetricsProvider, ChromeOSMetricsProvider, // ChromeOSMetricsProvider,
// SigninStatusMetricsProviderChromeOS, PrinterMetricsProvider, and // SigninStatusMetricsProviderChromeOS, PrinterMetricsProvider, and
// HashedLoggingMetricsProvider. // HashedLoggingMetricsProvider.
expected_providers += 7; expected_providers += 6;
#endif // defined(OS_CHROMEOS) #endif // defined(OS_CHROMEOS)
#if !defined(OS_CHROMEOS) #if !defined(OS_CHROMEOS)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment