Updater: Implement AppInstall::RegisterUpdater to register the updater.

Bug: 1128060
Change-Id: I787b44462a2154119e256725fd7b8bcac7d9f74d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617868Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Mila Green <milagreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842261}

chrome/updater/app/app_install.cc

@@ -143,14 +143,18 @@ void AppInstall::WakeCandidate() {
 }
 
 void AppInstall::RegisterUpdater() {
-  // TODO(crbug.com/1128060): We should update the updater's registration with
-  // the new version, brand code, etc. For now, fake it.
-  RegistrationResponse result;
-  result.status_code = 0;
-  RegisterUpdaterDone(result);
+  RegistrationRequest registration_request;
+  registration_request.app_id = kUpdaterAppId;
+  registration_request.version = base::Version(UPDATER_VERSION_STRING);
+
+  scoped_refptr<UpdateService> update_service = CreateUpdateService();
+  update_service->RegisterApp(
+      registration_request,
+      base::BindOnce(&AppInstall::RegisterUpdaterDone, this, update_service));
 }
 
-void AppInstall::RegisterUpdaterDone(const RegistrationResponse& response) {
+void AppInstall::RegisterUpdaterDone(scoped_refptr<UpdateService>,
+                                     const RegistrationResponse& response) {
   VLOG(1) << "Updater registration complete, code = " << response.status_code;
   MaybeInstallApp();
 }

chrome/updater/app/app_install.h

@@ -68,7 +68,8 @@ class AppInstall : public App {
 
   void RegisterUpdater();
 
-  void RegisterUpdaterDone(const RegistrationResponse& response);
+  void RegisterUpdaterDone(scoped_refptr<UpdateService>,
+                           const RegistrationResponse& response);
 
   // Handles the --tag and --app-id command line arguments, and triggers
   // installing of the corresponding application if either argument is present.

chrome/updater/win/update_service_proxy.cc

@@ -25,6 +25,7 @@
 #include "base/version.h"
 #include "base/win/scoped_bstr.h"
 #include "chrome/updater/app/server/win/updater_idl.h"
+#include "chrome/updater/registration_data.h"
 #include "chrome/updater/util.h"
 
 namespace updater {
@@ -302,7 +303,9 @@ void UpdateServiceProxy::RegisterApp(
     const RegistrationRequest& request,
     base::OnceCallback<void(const RegistrationResponse&)> callback) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
-  NOTREACHED();
+  // TODO(crbug.com/1163524): Implement registration API.
+  base::SequencedTaskRunnerHandle::Get()->PostTask(
+      FROM_HERE, base::BindOnce(std::move(callback), RegistrationResponse(0)));
 }
 
 void UpdateServiceProxy::UpdateAll(StateChangeCallback state_update,