Commit 2ca4e6ad authored by thakis's avatar thakis Committed by Commit bot

reflow comments in platform/{network,peerconnection}

BUG=563793

Review-Url: https://codereview.chromium.org/2389973004
Cr-Commit-Position: refs/heads/master@{#422606}
parent f83ed479
...@@ -108,7 +108,8 @@ TEST_F(EncodedFormDataTest, DeepCopy) { ...@@ -108,7 +108,8 @@ TEST_F(EncodedFormDataTest, DeepCopy) {
EXPECT_EQ(nullptr, copyElements[i].m_fileSystemURL.innerURL()); EXPECT_EQ(nullptr, copyElements[i].m_fileSystemURL.innerURL());
// m_optionalBlobDataHandle is not checked, because BlobDataHandle is ThreadSafeRefCounted. // m_optionalBlobDataHandle is not checked, because BlobDataHandle is
// ThreadSafeRefCounted.
} }
} }
......
...@@ -4,7 +4,8 @@ ...@@ -4,7 +4,8 @@
* (C) 2001 Dirk Mueller (mueller@kde.org) * (C) 2001 Dirk Mueller (mueller@kde.org)
* Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
* (C) 2006 Alexey Proskuryakov (ap@nypop.com) * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
* Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/) * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
* (http://www.torchmobile.com/)
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public * modify it under the terms of the GNU Library General Public
...@@ -52,8 +53,9 @@ static inline void appendPercentEncoded(Vector<char>& buffer, unsigned char c) { ...@@ -52,8 +53,9 @@ static inline void appendPercentEncoded(Vector<char>& buffer, unsigned char c) {
static void appendQuotedString(Vector<char>& buffer, const CString& string) { static void appendQuotedString(Vector<char>& buffer, const CString& string) {
// Append a string as a quoted value, escaping quotes and line breaks. // Append a string as a quoted value, escaping quotes and line breaks.
// FIXME: Is it correct to use percent escaping here? Other browsers do not encode these characters yet, // FIXME: Is it correct to use percent escaping here? Other browsers do not
// so we should test popular servers to find out if there is an encoding form they can handle. // encode these characters yet, so we should test popular servers to find out
// if there is an encoding form they can handle.
size_t length = string.length(); size_t length = string.length();
for (size_t i = 0; i < length; ++i) { for (size_t i = 0; i < length; ++i) {
char c = string.data()[i]; char c = string.data()[i];
...@@ -139,8 +141,8 @@ void FormDataEncoder::beginMultiPartHeader(Vector<char>& buffer, ...@@ -139,8 +141,8 @@ void FormDataEncoder::beginMultiPartHeader(Vector<char>& buffer,
const CString& name) { const CString& name) {
addBoundaryToMultiPartHeader(buffer, boundary); addBoundaryToMultiPartHeader(buffer, boundary);
// FIXME: This loses data irreversibly if the input name includes characters you can't encode // FIXME: This loses data irreversibly if the input name includes characters
// in the website's character set. // you can't encode in the website's character set.
append(buffer, "Content-Disposition: form-data; name=\""); append(buffer, "Content-Disposition: form-data; name=\"");
appendQuotedString(buffer, name); appendQuotedString(buffer, name);
append(buffer, '"'); append(buffer, '"');
...@@ -162,8 +164,8 @@ void FormDataEncoder::addFilenameToMultiPartHeader( ...@@ -162,8 +164,8 @@ void FormDataEncoder::addFilenameToMultiPartHeader(
Vector<char>& buffer, Vector<char>& buffer,
const WTF::TextEncoding& encoding, const WTF::TextEncoding& encoding,
const String& filename) { const String& filename) {
// FIXME: This loses data irreversibly if the filename includes characters you can't encode // FIXME: This loses data irreversibly if the filename includes characters you
// in the website's character set. // can't encode in the website's character set.
append(buffer, "; filename=\""); append(buffer, "; filename=\"");
appendQuotedString( appendQuotedString(
buffer, encoding.encode(filename, WTF::QuestionMarksForUnencodables)); buffer, encoding.encode(filename, WTF::QuestionMarksForUnencodables));
......
/* /*
* Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/) * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
* (http://www.torchmobile.com/)
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public * modify it under the terms of the GNU Library General Public
......
...@@ -41,7 +41,8 @@ namespace blink { ...@@ -41,7 +41,8 @@ namespace blink {
typedef Vector<std::pair<String, String>> CrossThreadHTTPHeaderMapData; typedef Vector<std::pair<String, String>> CrossThreadHTTPHeaderMapData;
// FIXME: Not every header fits into a map. Notably, multiple Set-Cookie header fields are needed to set multiple cookies. // FIXME: Not every header fits into a map. Notably, multiple Set-Cookie header
// fields are needed to set multiple cookies.
class PLATFORM_EXPORT HTTPHeaderMap final { class PLATFORM_EXPORT HTTPHeaderMap final {
DISALLOW_NEW(); DISALLOW_NEW();
......
...@@ -213,7 +213,8 @@ bool isValidHTTPFieldContentRFC7230(const String& value) { ...@@ -213,7 +213,8 @@ bool isValidHTTPFieldContentRFC7230(const String& value) {
for (unsigned i = 0; i < value.length(); ++i) { for (unsigned i = 0; i < value.length(); ++i) {
UChar c = value[i]; UChar c = value[i];
// TODO(mkwst): Extract this character class to a central location, https://crbug.com/527324. // TODO(mkwst): Extract this character class to a central location,
// https://crbug.com/527324.
if (c == 0x7F || c > 0xFF || (c < 0x20 && c != '\t')) if (c == 0x7F || c > 0xFF || (c < 0x20 && c != '\t'))
return false; return false;
} }
...@@ -320,8 +321,9 @@ bool parseHTTPRefresh(const String& refresh, ...@@ -320,8 +321,9 @@ bool parseHTTPRefresh(const String& refresh,
} }
// https://bugs.webkit.org/show_bug.cgi?id=27868 // https://bugs.webkit.org/show_bug.cgi?id=27868
// Sometimes there is no closing quote for the end of the URL even though there was an opening quote. // Sometimes there is no closing quote for the end of the URL even though
// If we looped over the entire alleged URL string back to the opening quote, just go ahead and use everything // there was an opening quote. If we looped over the entire alleged URL
// string back to the opening quote, just go ahead and use everything
// after the opening quote instead. // after the opening quote instead.
if (urlEndPos == urlStartPos) if (urlEndPos == urlStartPos)
urlEndPos = len; urlEndPos = len;
...@@ -358,11 +360,13 @@ AtomicString extractMIMETypeFromMediaType(const AtomicString& mediaType) { ...@@ -358,11 +360,13 @@ AtomicString extractMIMETypeFromMediaType(const AtomicString& mediaType) {
while (pos < length) { while (pos < length) {
UChar c = mediaType[pos]; UChar c = mediaType[pos];
// While RFC 2616 does not allow it, other browsers allow multiple values in the HTTP media // While RFC 2616 does not allow it, other browsers allow multiple values in
// type header field, Content-Type. In such cases, the media type string passed here may contain // the HTTP media type header field, Content-Type. In such cases, the media
// the multiple values separated by commas. For now, this code ignores text after the first comma, // type string passed here may contain the multiple values separated by
// which prevents it from simply failing to parse such types altogether. Later for better // commas. For now, this code ignores text after the first comma, which
// compatibility we could consider using the first or last valid MIME type instead. // prevents it from simply failing to parse such types altogether. Later
// for better compatibility we could consider using the first or last valid
// MIME type instead.
// See https://bugs.webkit.org/show_bug.cgi?id=25352 for more discussion. // See https://bugs.webkit.org/show_bug.cgi?id=25352 for more discussion.
if (c == ',' || c == ';') if (c == ',' || c == ';')
break; break;
...@@ -412,15 +416,16 @@ void findCharsetInMediaType(const String& mediaType, ...@@ -412,15 +416,16 @@ void findCharsetInMediaType(const String& mediaType,
while (pos != length && mediaType[pos] <= ' ') while (pos != length && mediaType[pos] <= ' ')
++pos; ++pos;
if (mediaType[pos++] != if (mediaType[pos++] != '=') // this "charset" substring wasn't a parameter
'=') // this "charset" substring wasn't a parameter name, but there may be others // name, but there may be others
continue; continue;
while (pos != length && (mediaType[pos] <= ' ' || mediaType[pos] == '"' || while (pos != length && (mediaType[pos] <= ' ' || mediaType[pos] == '"' ||
mediaType[pos] == '\'')) mediaType[pos] == '\''))
++pos; ++pos;
// we don't handle spaces within quoted parameter values, because charset names cannot have any // we don't handle spaces within quoted parameter values, because charset
// names cannot have any
unsigned endpos = pos; unsigned endpos = pos;
while (pos != length && mediaType[endpos] > ' ' && while (pos != length && mediaType[endpos] > ' ' &&
mediaType[endpos] != '"' && mediaType[endpos] != '\'' && mediaType[endpos] != '"' && mediaType[endpos] != '\'' &&
...@@ -471,7 +476,8 @@ ReflectedXSSDisposition parseXSSProtectionHeader(const String& header, ...@@ -471,7 +476,8 @@ ReflectedXSSDisposition parseXSSProtectionHeader(const String& header,
bool reportDirectiveSeen = false; bool reportDirectiveSeen = false;
while (1) { while (1) {
// At end of previous directive: consume whitespace, semicolon, and whitespace. // At end of previous directive: consume whitespace, semicolon, and
// whitespace.
if (!skipWhiteSpace(header, pos)) if (!skipWhiteSpace(header, pos))
return result; return result;
...@@ -614,7 +620,8 @@ static void parseCacheHeader(const String& header, ...@@ -614,7 +620,8 @@ static void parseCacheHeader(const String& header,
if (nextEqualSignPosition != kNotFound && if (nextEqualSignPosition != kNotFound &&
(nextEqualSignPosition < nextCommaPosition || (nextEqualSignPosition < nextCommaPosition ||
nextCommaPosition == kNotFound)) { nextCommaPosition == kNotFound)) {
// Get directive name, parse right hand side of equal sign, then add to map // Get directive name, parse right hand side of equal sign, then add to
// map
String directive = trimToNextSeparator( String directive = trimToNextSeparator(
safeHeader.substring(pos, nextEqualSignPosition - pos) safeHeader.substring(pos, nextEqualSignPosition - pos)
.stripWhiteSpace()); .stripWhiteSpace());
...@@ -705,8 +712,8 @@ CacheControlHeader parseCacheControlDirectives( ...@@ -705,8 +712,8 @@ CacheControlHeader parseCacheControlDirectives(
size_t directivesSize = directives.size(); size_t directivesSize = directives.size();
for (size_t i = 0; i < directivesSize; ++i) { for (size_t i = 0; i < directivesSize; ++i) {
// RFC2616 14.9.1: A no-cache directive with a value is only meaningful for proxy caches. // RFC2616 14.9.1: A no-cache directive with a value is only meaningful
// It should be ignored by a browser level cache. // for proxy caches. It should be ignored by a browser level cache.
if (equalIgnoringCase(directives[i].first, noCacheDirective) && if (equalIgnoringCase(directives[i].first, noCacheDirective) &&
directives[i].second.isEmpty()) { directives[i].second.isEmpty()) {
cacheControlHeader.containsNoCache = true; cacheControlHeader.containsNoCache = true;
...@@ -727,7 +734,8 @@ CacheControlHeader parseCacheControlDirectives( ...@@ -727,7 +734,8 @@ CacheControlHeader parseCacheControlDirectives(
} else if (equalIgnoringCase(directives[i].first, } else if (equalIgnoringCase(directives[i].first,
staleWhileRevalidateDirective)) { staleWhileRevalidateDirective)) {
if (!std::isnan(cacheControlHeader.staleWhileRevalidate)) { if (!std::isnan(cacheControlHeader.staleWhileRevalidate)) {
// First stale-while-revalidate directive wins if there are multiple ones. // First stale-while-revalidate directive wins if there are multiple
// ones.
continue; continue;
} }
bool ok; bool ok;
......
...@@ -62,7 +62,9 @@ enum XFrameOptionsDisposition { ...@@ -62,7 +62,9 @@ enum XFrameOptionsDisposition {
XFrameOptionsConflict XFrameOptionsConflict
}; };
// Be sure to update the behavior of XSSAuditor::combineXSSProtectionHeaderAndCSP whenever you change this enum's content or ordering. // Be sure to update the behavior of
// XSSAuditor::combineXSSProtectionHeaderAndCSP whenever you change this enum's
// content or ordering.
enum ReflectedXSSDisposition { enum ReflectedXSSDisposition {
ReflectedXSSUnset = 0, ReflectedXSSUnset = 0,
AllowReflectedXSS, AllowReflectedXSS,
......
...@@ -10,7 +10,8 @@ ...@@ -10,7 +10,8 @@
namespace blink { namespace blink {
// Verify that the parameter is a link-extension which according to spec doesn't have to have a value. // Verify that the parameter is a link-extension which according to spec doesn't
// have to have a value.
static bool isExtensionParameter(LinkHeader::LinkParameterName name) { static bool isExtensionParameter(LinkHeader::LinkParameterName name) {
return name >= LinkHeader::LinkParameterUnknown; return name >= LinkHeader::LinkParameterUnknown;
} }
......
...@@ -53,7 +53,8 @@ class PLATFORM_EXPORT ParsedContentType final { ...@@ -53,7 +53,8 @@ class PLATFORM_EXPORT ParsedContentType final {
String mimeType() const { return m_mimeType; } String mimeType() const { return m_mimeType; }
String charset() const; String charset() const;
// Note that in the case of multiple values for the same name, the last value is returned. // Note that in the case of multiple values for the same name, the last value
// is returned.
String parameterValueForName(const String&) const; String parameterValueForName(const String&) const;
size_t parameterCount() const; size_t parameterCount() const;
......
...@@ -34,8 +34,8 @@ ...@@ -34,8 +34,8 @@
namespace blink { namespace blink {
PLATFORM_EXPORT extern const char errorDomainBlinkInternal // Used for errors that won't be exposed to clients.
[]; // Used for errors that won't be exposed to clients. PLATFORM_EXPORT extern const char errorDomainBlinkInternal[];
class PLATFORM_EXPORT ResourceError final { class PLATFORM_EXPORT ResourceError final {
DISALLOW_NEW(); DISALLOW_NEW();
...@@ -68,7 +68,8 @@ class PLATFORM_EXPORT ResourceError final { ...@@ -68,7 +68,8 @@ class PLATFORM_EXPORT ResourceError final {
m_staleCopyInCache(false), m_staleCopyInCache(false),
m_wasIgnoredByHandler(false) {} m_wasIgnoredByHandler(false) {}
// Makes a deep copy. Useful for when you need to use a ResourceError on another thread. // Makes a deep copy. Useful for when you need to use a ResourceError on
// another thread.
ResourceError copy() const; ResourceError copy() const;
bool isNull() const { return m_isNull; } bool isNull() const { return m_isNull; }
......
...@@ -81,11 +81,15 @@ class PLATFORM_EXPORT ResourceLoadTiming ...@@ -81,11 +81,15 @@ class PLATFORM_EXPORT ResourceLoadTiming
private: private:
ResourceLoadTiming(); ResourceLoadTiming();
// We want to present a unified timeline to Javascript. Using walltime is problematic, because the clock may skew while resources // We want to present a unified timeline to Javascript. Using walltime is
// load. To prevent that skew, we record a single reference walltime when root document navigation begins. All other times are // problematic, because the clock may skew while resources load. To prevent
// recorded using monotonicallyIncreasingTime(). When a time needs to be presented to Javascript, we build a pseudo-walltime // that skew, we record a single reference walltime when root document
// using the following equation (m_requestTime as example): // navigation begins. All other times are recorded using
// pseudo time = document wall reference + (m_requestTime - document monotonic reference). // monotonicallyIncreasingTime(). When a time needs to be presented to
// Javascript, we build a pseudo-walltime using the following equation
// (m_requestTime as example):
// pseudo time = document wall reference +
// (m_requestTime - document monotonic reference).
// All monotonicallyIncreasingTime() in seconds // All monotonicallyIncreasingTime() in seconds
double m_requestTime; double m_requestTime;
......
...@@ -338,8 +338,9 @@ void ResourceRequest::setExternalRequestStateFromRequestorAddressSpace( ...@@ -338,8 +338,9 @@ void ResourceRequest::setExternalRequestStateFromRequestorAddressSpace(
static_assert(WebAddressSpacePrivate < WebAddressSpacePublic, static_assert(WebAddressSpacePrivate < WebAddressSpacePublic,
"Private is inside Public"); "Private is inside Public");
// TODO(mkwst): This only checks explicit IP addresses. We'll have to move all this up to //net and //content in // TODO(mkwst): This only checks explicit IP addresses. We'll have to move all
// order to have any real impact on gateway attacks. That turns out to be a TON of work. https://crbug.com/378566 // this up to //net and //content in order to have any real impact on gateway
// attacks. That turns out to be a TON of work. https://crbug.com/378566
if (!RuntimeEnabledFeatures::corsRFC1918Enabled()) { if (!RuntimeEnabledFeatures::corsRFC1918Enabled()) {
m_isExternalRequest = false; m_isExternalRequest = false;
return; return;
......
...@@ -174,7 +174,8 @@ class PLATFORM_EXPORT ResourceRequest final { ...@@ -174,7 +174,8 @@ class PLATFORM_EXPORT ResourceRequest final {
m_reportUploadProgress = reportUploadProgress; m_reportUploadProgress = reportUploadProgress;
} }
// Whether actual headers being sent/received should be collected and reported for the request. // Whether actual headers being sent/received should be collected and reported
// for the request.
bool reportRawHeaders() const { return m_reportRawHeaders; } bool reportRawHeaders() const { return m_reportRawHeaders; }
void setReportRawHeaders(bool reportRawHeaders) { void setReportRawHeaders(bool reportRawHeaders) {
m_reportRawHeaders = reportRawHeaders; m_reportRawHeaders = reportRawHeaders;
...@@ -309,8 +310,8 @@ class PLATFORM_EXPORT ResourceRequest final { ...@@ -309,8 +310,8 @@ class PLATFORM_EXPORT ResourceRequest final {
KURL m_url; KURL m_url;
WebCachePolicy m_cachePolicy; WebCachePolicy m_cachePolicy;
double double m_timeoutInterval; // 0 is a magic value for platform default on
m_timeoutInterval; // 0 is a magic value for platform default on platforms that have one. // platforms that have one.
KURL m_firstPartyForCookies; KURL m_firstPartyForCookies;
RefPtr<SecurityOrigin> m_requestorOrigin; RefPtr<SecurityOrigin> m_requestorOrigin;
AtomicString m_httpMethod; AtomicString m_httpMethod;
......
...@@ -284,7 +284,8 @@ const AtomicString& ResourceResponse::mimeType() const { ...@@ -284,7 +284,8 @@ const AtomicString& ResourceResponse::mimeType() const {
void ResourceResponse::setMimeType(const AtomicString& mimeType) { void ResourceResponse::setMimeType(const AtomicString& mimeType) {
m_isNull = false; m_isNull = false;
// FIXME: MIME type is determined by HTTP Content-Type header. We should update the header, so that it doesn't disagree with m_mimeType. // FIXME: MIME type is determined by HTTP Content-Type header. We should
// update the header, so that it doesn't disagree with m_mimeType.
m_mimeType = mimeType; m_mimeType = mimeType;
} }
...@@ -296,7 +297,9 @@ void ResourceResponse::setExpectedContentLength( ...@@ -296,7 +297,9 @@ void ResourceResponse::setExpectedContentLength(
long long expectedContentLength) { long long expectedContentLength) {
m_isNull = false; m_isNull = false;
// FIXME: Content length is determined by HTTP Content-Length header. We should update the header, so that it doesn't disagree with m_expectedContentLength. // FIXME: Content length is determined by HTTP Content-Length header. We
// should update the header, so that it doesn't disagree with
// m_expectedContentLength.
m_expectedContentLength = expectedContentLength; m_expectedContentLength = expectedContentLength;
} }
...@@ -307,7 +310,8 @@ const AtomicString& ResourceResponse::textEncodingName() const { ...@@ -307,7 +310,8 @@ const AtomicString& ResourceResponse::textEncodingName() const {
void ResourceResponse::setTextEncodingName(const AtomicString& encodingName) { void ResourceResponse::setTextEncodingName(const AtomicString& encodingName) {
m_isNull = false; m_isNull = false;
// FIXME: Text encoding is determined by HTTP Content-Type header. We should update the header, so that it doesn't disagree with m_textEncodingName. // FIXME: Text encoding is determined by HTTP Content-Type header. We should
// update the header, so that it doesn't disagree with m_textEncodingName.
m_textEncodingName = encodingName; m_textEncodingName = encodingName;
} }
...@@ -319,7 +323,8 @@ const String& ResourceResponse::suggestedFilename() const { ...@@ -319,7 +323,8 @@ const String& ResourceResponse::suggestedFilename() const {
void ResourceResponse::setSuggestedFilename(const String& suggestedName) { void ResourceResponse::setSuggestedFilename(const String& suggestedName) {
m_isNull = false; m_isNull = false;
// FIXME: Suggested file name is calculated based on other headers. There should not be a setter for it. // FIXME: Suggested file name is calculated based on other headers. There
// should not be a setter for it.
m_suggestedFilename = suggestedName; m_suggestedFilename = suggestedName;
} }
......
...@@ -105,7 +105,8 @@ class PLATFORM_EXPORT ResourceResponse final { ...@@ -105,7 +105,8 @@ class PLATFORM_EXPORT ResourceResponse final {
// All strings are human-readable values. // All strings are human-readable values.
String protocol; String protocol;
String keyExchange; String keyExchange;
// keyExchangeGroup is the empty string if not applicable for the connection's key exchange. // keyExchangeGroup is the empty string if not applicable for the
// connection's key exchange.
String keyExchangeGroup; String keyExchangeGroup;
String cipher; String cipher;
// mac is the empty string when the connection cipher suite does not // mac is the empty string when the connection cipher suite does not
...@@ -156,7 +157,9 @@ class PLATFORM_EXPORT ResourceResponse final { ...@@ -156,7 +157,9 @@ class PLATFORM_EXPORT ResourceResponse final {
void setTextEncodingName(const AtomicString&); void setTextEncodingName(const AtomicString&);
// FIXME: Should compute this on the fly. // FIXME: Should compute this on the fly.
// There should not be a setter exposed, as suggested file name is determined based on other headers in a manner that WebCore does not necessarily know about. // There should not be a setter exposed, as suggested file name is determined
// based on other headers in a manner that WebCore does not necessarily know
// about.
const String& suggestedFilename() const; const String& suggestedFilename() const;
void setSuggestedFilename(const String&); void setSuggestedFilename(const String&);
...@@ -176,7 +179,8 @@ class PLATFORM_EXPORT ResourceResponse final { ...@@ -176,7 +179,8 @@ class PLATFORM_EXPORT ResourceResponse final {
bool isAttachment() const; bool isAttachment() const;
// FIXME: These are used by PluginStream on some platforms. Calculations may differ from just returning plain Last-Modified header. // FIXME: These are used by PluginStream on some platforms. Calculations may
// differ from just returning plain Last-Modified header.
// Leaving it for now but this should go away in favor of generic solution. // Leaving it for now but this should go away in favor of generic solution.
void setLastModifiedDate(time_t); void setLastModifiedDate(time_t);
time_t lastModifiedDate() const; time_t lastModifiedDate() const;
...@@ -407,10 +411,12 @@ class PLATFORM_EXPORT ResourceResponse final { ...@@ -407,10 +411,12 @@ class PLATFORM_EXPORT ResourceResponse final {
// Was the resource fetched over SPDY. See http://dev.chromium.org/spdy // Was the resource fetched over SPDY. See http://dev.chromium.org/spdy
bool m_wasFetchedViaSPDY; bool m_wasFetchedViaSPDY;
// Was the resource fetched over a channel which used TLS/Next-Protocol-Negotiation (also SPDY related). // Was the resource fetched over a channel which used
// TLS/Next-Protocol-Negotiation (also SPDY related).
bool m_wasNpnNegotiated; bool m_wasNpnNegotiated;
// Was the resource fetched over a channel which specified "Alternate-Protocol" // Was the resource fetched over a channel which specified
// "Alternate-Protocol"
// (e.g.: Alternate-Protocol: 443:npn-spdy/1). // (e.g.: Alternate-Protocol: 443:npn-spdy/1).
bool m_wasAlternateProtocolAvailable; bool m_wasAlternateProtocolAvailable;
......
...@@ -61,8 +61,8 @@ class PLATFORM_EXPORT WebSocketHandshakeRequest final ...@@ -61,8 +61,8 @@ class PLATFORM_EXPORT WebSocketHandshakeRequest final
addAndMergeHeader(&m_headerFields, name, value); addAndMergeHeader(&m_headerFields, name, value);
} }
// Merges the existing value with |value| in |map| if |map| already has |name|. // Merges the existing value with |value| in |map| if |map| already has
// Associates |value| with |name| in |map| otherwise. // |name|. Associates |value| with |name| in |map| otherwise.
// This function builds data for inspector. // This function builds data for inspector.
static void addAndMergeHeader(HTTPHeaderMap* /* map */, static void addAndMergeHeader(HTTPHeaderMap* /* map */,
const AtomicString& name, const AtomicString& name,
......
...@@ -10,16 +10,16 @@ ...@@ -10,16 +10,16 @@
* notice, this list of conditions and the following disclaimer in the * notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution. * documentation and/or other materials provided with the distribution.
* *
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#ifndef RTCStatsResponseBase_h #ifndef RTCStatsResponseBase_h
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment