Commit 2ca8e7a2 authored by Patrick Noland's avatar Patrick Noland Committed by Commit Bot

[ToolbarMVC] Dont call setThemeColorProvider on MenuButton in TTC

The existing code mistakenly sets the ThemeColorProvider to the TabThemeColorProvider, which is wrong for CustomTabToolbar, and is redundant considering we now constructor inject it.

Bug: 1128337
Change-Id: I8c2e7c402d433a56f14218c1cdbe46554dcf13fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422340
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809579}
parent 5e7b5b42
...@@ -143,10 +143,6 @@ public class TopToolbarCoordinator implements Toolbar { ...@@ -143,10 +143,6 @@ public class TopToolbarCoordinator implements Toolbar {
HomepageManager.getInstance().addListener(mHomepageStateListener); HomepageManager.getInstance().addListener(mHomepageStateListener);
mToolbarLayout.initialize(toolbarDataProvider, tabController, mMenuButtonCoordinator); mToolbarLayout.initialize(toolbarDataProvider, tabController, mMenuButtonCoordinator);
final MenuButton menuButtonWrapper = getMenuButtonWrapper();
if (menuButtonWrapper != null) {
menuButtonWrapper.setThemeColorProvider(normalThemeColorProvider);
}
mToolbarLayout.setThemeColorProvider(normalThemeColorProvider); mToolbarLayout.setThemeColorProvider(normalThemeColorProvider);
mAppMenuButtonHelperSupplier = appMenuButtonHelperSupplier; mAppMenuButtonHelperSupplier = appMenuButtonHelperSupplier;
new OneShotCallback<>(mAppMenuButtonHelperSupplier, this::setAppMenuButtonHelper); new OneShotCallback<>(mAppMenuButtonHelperSupplier, this::setAppMenuButtonHelper);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment