Commit 2cbd3696 authored by Chan Li's avatar Chan Li Committed by Commit Bot

Re-enable "chromium.resultdb.result_sink" experiment on chromium ci builders at 10%

Bug: 1108016
Change-Id: I5e63664b302698c805361043113d940432c5907e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485050Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818628}
parent b7db1774
This source diff could not be displayed because it is too large. You can view the blob instead.
...@@ -339,6 +339,7 @@ def ci_builder( ...@@ -339,6 +339,7 @@ def ci_builder(
tree_closing = False, tree_closing = False,
notifies = None, notifies = None,
resultdb_bigquery_exports = None, resultdb_bigquery_exports = None,
experiments = None,
**kwargs): **kwargs):
"""Define a CI builder. """Define a CI builder.
...@@ -376,6 +377,8 @@ def ci_builder( ...@@ -376,6 +377,8 @@ def ci_builder(
specifying additional parameters for exporting test results to BigQuery. specifying additional parameters for exporting test results to BigQuery.
Will always upload to the luci-resultdb.chromium.ci_test_results table Will always upload to the luci-resultdb.chromium.ci_test_results table
in addition to any tables specified by the list's elements. in addition to any tables specified by the list's elements.
experiments - a dict of experiment name to the percentage chance (0-100)
that it will apply to builds generated from this builder.
""" """
if not branches.matches(branch_selector): if not branches.matches(branch_selector):
return return
...@@ -393,6 +396,10 @@ def ci_builder( ...@@ -393,6 +396,10 @@ def ci_builder(
] ]
merged_resultdb_bigquery_exports.extend(resultdb_bigquery_exports or []) merged_resultdb_bigquery_exports.extend(resultdb_bigquery_exports or [])
# Enable "chromium.resultdb.result_sink" on all ci builders for 10% by default.
experiments = experiments or {}
experiments.setdefault("chromium.resultdb.result_sink", 10)
# Define the builder first so that any validation of luci.builder arguments # Define the builder first so that any validation of luci.builder arguments
# (e.g. bucket) occurs before we try to use it # (e.g. bucket) occurs before we try to use it
builders.builder( builders.builder(
...@@ -400,6 +407,7 @@ def ci_builder( ...@@ -400,6 +407,7 @@ def ci_builder(
branch_selector = branch_selector, branch_selector = branch_selector,
resultdb_bigquery_exports = merged_resultdb_bigquery_exports, resultdb_bigquery_exports = merged_resultdb_bigquery_exports,
notifies = notifies, notifies = notifies,
experiments = experiments,
**kwargs **kwargs
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment