Revert "[Nav Experiment] Skip SSL status update when webview is loading."
This reverts commit 9441c306. Reason for revert: Breaks ExternalURLSSLTestCase/testMixedContentWarning in the downstream tree. https://browsingtest.appspot.com/mixedContent.html does not show a mixed content warning. Original change's description: > [Nav Experiment] Skip SSL status update when webview is loading. > > -webViewSecurityFeaturesDidChange is meant to update the SSL status of > the last committed item. With WKBasedNavigationManager, on a back/forard > navigation, there exists a small window between web view starts loading > and -webView:didStartProvisionalNavigation is triggered that > WKBasedNavigationManager::GetLastCommittedItem() returns the pending > item instead of the last committed item. > -updateSSLStatusForCurrentNavigationItem must not be called in this > window, otherwise the wrong navigation item will be used. > > Bug: 842151 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I57eb96f74c3a6a133b1fdad6559de093f5d125c5 > Reviewed-on: https://chromium-review.googlesource.com/1141054 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575803} TBR=kkhorimoto@chromium.org,danyao@chromium.org Change-Id: Ia764eeca4fcb26cc3cf9cd8778fe4cedb5e98c3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1141384Reviewed-by:Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575896}
Showing
Please register or sign in to comment