Commit 2d18c70c authored by Bartek Nowierski's avatar Bartek Nowierski Committed by Commit Bot

Adding some more fields to manual-fields-to-ignore.txt.

The latest rewrite attempt revealed a couple more classes of compiler
errors, that would be hard to handle automatically in the rewriter.

Bug: 1069567
Change-Id: I844bd3f6bd8e562b8869702bfc55002557254580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255920
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781272}
parent d1bd596a
...@@ -69,8 +69,9 @@ blink::Worklist::PrivateSegmentHolder::private_push_segment ...@@ -69,8 +69,9 @@ blink::Worklist::PrivateSegmentHolder::private_push_segment
content::(anonymous namespace)::AudioStreamMonitorTest::monitor_ content::(anonymous namespace)::AudioStreamMonitorTest::monitor_
content::AudioStreamMonitor::clock_ content::AudioStreamMonitor::clock_
# Populated manually - always holds OilPan pointers. # Populated manually - always holds a pointer to an OilPan-allocated memory.
blink::PersistentBase::raw_ blink::PersistentBase::raw_
blink::SVGFilterBuilder::last_effect_
# Populated manually - the rewriter has trouble appending |.get()| inside macros # Populated manually - the rewriter has trouble appending |.get()| inside macros
# that work with |XDisplay*|. # that work with |XDisplay*|.
...@@ -78,6 +79,7 @@ extensions::GlobalShortcutListenerX11::x_display_ ...@@ -78,6 +79,7 @@ extensions::GlobalShortcutListenerX11::x_display_
gl::GLVisualPickerGLX::display_ gl::GLVisualPickerGLX::display_
media::(anonymous namespace)::UserInputMonitorLinuxCore::x_record_display_ media::(anonymous namespace)::UserInputMonitorLinuxCore::x_record_display_
media::cast::test::LinuxOutputWindow::display_ media::cast::test::LinuxOutputWindow::display_
remoting::(anonymous namespace)::InputInjectorX11::Core::display_
remoting::(anonymous namespace)::LocalHotkeyInputMonitorX11::Core::x_record_display_ remoting::(anonymous namespace)::LocalHotkeyInputMonitorX11::Core::x_record_display_
remoting::(anonymous namespace)::LocalMouseInputMonitorX11::Core::x_record_display_ remoting::(anonymous namespace)::LocalMouseInputMonitorX11::Core::x_record_display_
remoting::ClipboardX11::display_ remoting::ClipboardX11::display_
...@@ -134,14 +136,14 @@ blink::PaintController::IdAsHashKey::client ...@@ -134,14 +136,14 @@ blink::PaintController::IdAsHashKey::client
ui::AXPlatformNodeAuraLinux::document_parent_ ui::AXPlatformNodeAuraLinux::document_parent_
ui::AXPlatformNodeAuraLinux::atk_object_ ui::AXPlatformNodeAuraLinux::atk_object_
# Populated manually - to temporarily avoid passing CheckedPtr as # Populated manually - problems related to passing to a templated && parameter,
# an argument to TRACE_EVENT* family of macros. # which is later forwarded to something that doesn't vibe with CheckedPtr. The
# rewriter has no visibility into where the parameter is forwarded to.
ProfileDestroyer::profile_ ProfileDestroyer::profile_
content::RenderProcessHostImpl::browser_context_
# Populated manually - problems related to testing::StrictMock and
# testing::NiceMock (needs more investigation / problem not full understood).
(anonymous namespace)::BluetoothLowEnergyApiTest::mock_adapter_ (anonymous namespace)::BluetoothLowEnergyApiTest::mock_adapter_
blink::trace_event::TraceValue::as_convertable
content::RenderProcessHostImpl::browser_context_
device::BluetoothDevice::adapter_
# Populated manually - problems related to lambdas with no return type, where # Populated manually - problems related to lambdas with no return type, where
# the return value is CheckedPtr, but variable/parameter receiving the lambda # the return value is CheckedPtr, but variable/parameter receiving the lambda
...@@ -152,8 +154,7 @@ vr::OmniboxSuggestion::icon ...@@ -152,8 +154,7 @@ vr::OmniboxSuggestion::icon
# Populated manually - these pointers are assigned invalid address (with top # Populated manually - these pointers are assigned invalid address (with top
# bits sets), which CheckedPtr is unable to handle, leading to run-time crashes. # bits sets), which CheckedPtr is unable to handle, leading to run-time crashes.
(anonymous namespace)::TlsVectorEntry::data (anonymous namespace)::TlsVectorEntry::data
blink::(anonymous namespace)::ControlKey::name_
blink::(anonymous namespace)::ControlKey::type_
blink::(anonymous namespace)::ThreadMarker::creating_thread_ blink::(anonymous namespace)::ThreadMarker::creating_thread_
blink::ControlKey::name_
performance_manager::frame_priority::BoostingVoteAggregator::Edge::src_ performance_manager::frame_priority::BoostingVoteAggregator::Edge::src_
performance_manager::frame_priority::BoostingVoteAggregator::Edge::dst_ performance_manager::frame_priority::BoostingVoteAggregator::Edge::dst_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment